Why do CameraFrame and HorizonFrame need an ArrayPointing
#505
Labels
Comments
|
I think the coordinate transforms are a bit backward and need reworking (see e.g. #416) |
|
Short answer, they don't. However if they are defined here then a direct transformation can be performed all they way through all the systems. e.g. from camera directly to Horizon. Agreed this needs restructuring though. |
|
Why does a transform from The individual pointing of the Telescope should be enough. |
|
Yes, it doesn't but some of the frames in between do. Currently the coordinates transform doesn't bypass any systems, such as the system centred on the nominal array pointing direction, but that is easy to change in the astropy structure. |
|
fixed in #896 |
dneise
pushed a commit
that referenced
this issue
Jan 23, 2019
* Start refactoring coordinates * Update frame attributes for NominalFrame * Remove weird module check * Fix coordinate usage in muon code * Set argv for tool tests, fixes error when using pytest options * Add roudtrip test * Names to pointings and docstrings. * Renaming in tests and coordinates. no abbreviations. * Fix kwargs * More renames * Use QuantityAttributes were appropriate * Use default=0 for focal_length * More coordinate fixing * More coordinate fixes * Fix coordinate trafo example * Make HorizonFrame an alias to altaz * Add test showing it is possible to go from ICRS to camera frame * Add test that shows separation of planar frame is broken * Add coordinate attribute back * Implement nominal and telescopeframe like skyoffsetframe * Fix imports * Add missing rotation attribute, call it x and y again * Allow transforming of AltAz into AltAz without obstime or location * Use UnitSphericalRepresentation, add tests * Use approx * Use correct representation in camera to telescope * Remove outdated examples * Fix __all__ * Update docstrings * Add example to plot stereo showers * Ugly fix for doc warnings * Fix invalid syntax * Fix style issues * Add test that shows transformation into camera is broken * Wrap TelescopeFrame and NominalFrame angles at 180° * Add comment about mapping function * Rename Telescope and Nominal frame attributes to delta_az, delta_alt, fix camera coordinate trafo * Do not set astropy config at import * Remove comment about iers from docs * Update nominal_frame.py * Update telescope_frame.py * Update docstring of camera coordinate * Start reworking coord docs
watsonjj
added a commit
to watsonjj/ctapipe
that referenced
this issue
Jan 23, 2019
* master: Major coordinate refactoring, fixes cta-observatory#899, cta-observatory#900, cta-observatory#505, cta-observatory#416 (cta-observatory#896) speed up is_compatible; makes event_source factory faster (cta-observatory#927) Prefix containers (cta-observatory#833) remove optional deps in order to fix tests (cta-observatory#925) Charge Resolution Update (cta-observatory#827) Remove serializer, fixes cta-observatory#887 (cta-observatory#913) deleted summary.html - accidentally committed file (cta-observatory#919) # Conflicts: # ctapipe/tools/extract_charge_resolution.py # examples/simple_event_writer.py
|
Solved in #896 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Transformation from Camera Coordinates to sky coordinates should only require the pointing of the single telescopes, or not?
The text was updated successfully, but these errors were encountered: