Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use SkyOffsetFrame for TelescopeFrame and NominalFrame #899

Closed
maxnoe opened this issue Dec 13, 2018 · 3 comments
Closed

Use SkyOffsetFrame for TelescopeFrame and NominalFrame #899

maxnoe opened this issue Dec 13, 2018 · 3 comments
Labels
coordinates enhancement proposal

Comments

@maxnoe
Copy link
Member

maxnoe commented Dec 13, 2018

It sound like we could just use astropy's SkyOffsetFrame for TelescopeFrame and NominalFrame, as these are basically AltAz Frames offset from the telescope pointing position or an arbitrary sky position.
@maxnoe
Copy link
Member Author

maxnoe commented Dec 13, 2018

http://docs.astropy.org/en/stable/_modules/astropy/coordinates/builtin_frames/skyoffset.html#SkyOffsetFrame

@thomasgas
Copy link

Looks nice!

@maxnoe maxnoe mentioned this issue Dec 13, 2018
Closed
@maxnoe
Copy link
Member Author

maxnoe commented Dec 14, 2018

Done in #896

@dneise dneise closed this as completed in cc1567d Jan 23, 2019
watsonjj added a commit to watsonjj/ctapipe that referenced this issue Jan 23, 2019
@watsonjj
Merge branch 'master' into factory_v3
7d0f868 
* master:
  Major coordinate refactoring, fixes cta-observatory#899, cta-observatory#900, cta-observatory#505, cta-observatory#416 (cta-observatory#896)
  speed up is_compatible; makes event_source factory faster (cta-observatory#927)
  Prefix containers (cta-observatory#833)
  remove optional deps in order to fix tests (cta-observatory#925)
  Charge Resolution Update (cta-observatory#827)
  Remove serializer, fixes cta-observatory#887 (cta-observatory#913)
  deleted summary.html - accidentally committed file (cta-observatory#919)

# Conflicts:
#	ctapipe/tools/extract_charge_resolution.py
#	examples/simple_event_writer.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
coordinates enhancement proposal
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@maxnoe @thomasgas