Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: chain-id is not parsed from genesis config #1217

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Oct 20, 2023

Solution:

  • simpliy use the default behavior in sdk

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

  • Bug Fix: Resolved an issue with concurrent write in fee history, enhancing the reliability of transactions.
  • Refactor: Simplified the chain ID setup process in the SDK, removing unnecessary code for a cleaner, more efficient system. This change streamlines the underlying processes, but won't affect the user experience directly.

Solution:
- simpliy use the default behavior in sdk
@yihuang yihuang requested a review from a team as a code owner October 20, 2023 06:31
@yihuang yihuang requested review from mmsqe and thomas-nguy and removed request for a team October 20, 2023 06:31
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 24, 2023

Walkthrough

This pull request primarily focuses on enhancing the concurrency handling in fee history and refining the default chain-id behavior in the SDK. It also eliminates unnecessary code and imports related to chain ID setup and configuration in root.go.

Changes

File Summary
CHANGELOG.md Documents the bug fix related to concurrent write in fee history and the update in default chain-id behavior in the SDK.
cmd/cronosd/cmd/root.go Removes unnecessary imports and code related to chain ID setup and configuration.

🐇

In the land of code, where logic intertwines,

Bugs are squashed, and the sun shines.

Unnecessary clutter, we bid adieu,

For simplicity and efficiency, we pursue. 🚀


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 44d0284 and 7ff278f.
Files selected for processing (2)
  • CHANGELOG.md (1 hunks)
  • cmd/cronosd/cmd/root.go (2 hunks)
Files skipped from review due to trivial changes (2)
  • CHANGELOG.md
  • cmd/cronosd/cmd/root.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants