-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: redundant parse chainID from gensis when start server #1216
Conversation
aa47d9a
to
ed641eb
Compare
667be5c
to
ed296db
Compare
WalkthroughThis update brings a series of enhancements and fixes to the system. It addresses a concurrent write issue in Ethermint's fee history, modifies the default chain-id behavior in the SDK, and optimizes Ethermint to avoid redundant parsing of chainID. Additionally, a new test case has been added to verify the configuration of the client ID in the Cronos blockchain, and a fix has been implemented for the mem store in versiondb multistore. Changes
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to filter (3)
- go.mod
- go.sum
- gomod2nix.toml
Files selected for processing (2)
- CHANGELOG.md (1} hunks)
- integration_tests/test_client_id.py (1} hunks)
Files skipped from review due to trivial changes (1)
- CHANGELOG.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files selected for processing (1)
- integration_tests/test_client_id.py (1} hunks)
Additional comments: 1
integration_tests/test_client_id.py (1)
- 9-32: The test case
test_config_client_id
is well written and covers the scenario of changing the chain ID in the genesis configuration file. It first tests that starting with an empty chain ID should fail, then it tests that the node starts successfully with a valid chain ID. The test also verifies that the Ethereum chain ID is set correctly. However, there is a potential issue with the way the chain ID is being updated in the genesis file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻
PR Checklist:
make
)make test
)go fmt
)golangci-lint run
)go list -json -m all | nancy sleuth
)Thank you for your code, it's appreciated! :)
Summary by CodeRabbit
test_config_client_id
to validate the correct configuration of the client ID in the Cronos blockchain, ensuring the system's robustness and reliability.