Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: redundant parse chainID from gensis when start server #1216

Merged
merged 4 commits into from
Oct 27, 2023

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Oct 20, 2023

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

@mmsqe mmsqe force-pushed the enforce_chain_id branch 2 times, most recently from aa47d9a to ed641eb Compare October 20, 2023 04:41
@mmsqe mmsqe marked this pull request as ready for review October 20, 2023 04:41
@mmsqe mmsqe requested a review from a team as a code owner October 20, 2023 04:41
@mmsqe mmsqe requested review from calvinaco and leejw51crypto and removed request for a team October 20, 2023 04:41
@mmsqe mmsqe marked this pull request as draft October 20, 2023 05:00
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Oct 27, 2023

Walkthrough

This update brings a series of enhancements and fixes to the system. It addresses a concurrent write issue in Ethermint's fee history, modifies the default chain-id behavior in the SDK, and optimizes Ethermint to avoid redundant parsing of chainID. Additionally, a new test case has been added to verify the configuration of the client ID in the Cronos blockchain, and a fix has been implemented for the mem store in versiondb multistore.

Changes

File Summary
CHANGELOG.md Includes four pull requests addressing various issues and enhancements in Ethermint and the SDK.
integration_tests/test_client_id.py Adds a new test function test_config_client_id to verify the configuration of the client ID in the Cronos blockchain.

"In the land of code, where the shadows lie,

Four pull requests, under the digital sky,

One by one, they dance and twirl,

In the bright world of the binary swirl.

A test is born, a bug is slain,

In the endless cycle of code's domain.

So, let's celebrate this day with cheer,

For the code is clear, and the logic is dear! 🎉🐇"


Tips

Chat with CodeRabbit Bot (@coderabbitai)

  • If you reply to a review comment from CodeRabbit, the bot will automatically respond.
  • To engage with CodeRabbit bot directly around the specific lines of code in the PR, mention @coderabbitai in your review comment
  • Note: Review comments are made on code diffs or files, not on the PR overview.
  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai help to get help.

Note: For conversation with the bot, please use the review comments on code diffs or files.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.json

@mmsqe mmsqe changed the title Problem: chainID config in client.toml is not enforced Problem: redundant parse chainID from gensis when start server Oct 27, 2023
go.mod Show resolved Hide resolved
@mmsqe mmsqe marked this pull request as ready for review October 27, 2023 03:15
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between b9de162 and ed296db.
Files ignored due to filter (3)
  • go.mod
  • go.sum
  • gomod2nix.toml
Files selected for processing (2)
  • CHANGELOG.md (1} hunks)
  • integration_tests/test_client_id.py (1} hunks)
Files skipped from review due to trivial changes (1)
  • CHANGELOG.md

integration_tests/test_client_id.py Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 2

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between ed296db and bcefb10.
Files selected for processing (1)
  • integration_tests/test_client_id.py (1} hunks)

integration_tests/test_client_id.py Outdated Show resolved Hide resolved
integration_tests/test_client_id.py Outdated Show resolved Hide resolved
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between bcefb10 and 6b80a9d.
Files selected for processing (1)
  • integration_tests/test_client_id.py (1} hunks)
Additional comments: 1
integration_tests/test_client_id.py (1)
  • 9-32: The test case test_config_client_id is well written and covers the scenario of changing the chain ID in the genesis configuration file. It first tests that starting with an empty chain ID should fail, then it tests that the node starts successfully with a valid chain ID. The test also verifies that the Ethereum chain ID is set correctly. However, there is a potential issue with the way the chain ID is being updated in the genesis file.

integration_tests/test_client_id.py Show resolved Hide resolved
@mmsqe mmsqe enabled auto-merge October 27, 2023 07:32
@mmsqe mmsqe added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@mmsqe mmsqe enabled auto-merge October 27, 2023 09:22
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 1

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 6b80a9d and e174577.
Files selected for processing (1)
  • CHANGELOG.md (1} hunks)

CHANGELOG.md Show resolved Hide resolved
@mmsqe mmsqe added this pull request to the merge queue Oct 27, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 27, 2023
@mmsqe mmsqe added this pull request to the merge queue Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants