Problem: no validate for malformed e2ee key in register

[mmsqe]

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

• Have you read the CONTRIBUTING.md?
• Does your PR follow the C4 patch requirements?
• Have you rebased your work on top of the latest master?
• Have you checked your code compiles? (make)
• Have you included tests for any non-trivial functionality?
• Have you checked your code passes the unit tests? (make test)
• Have you checked your code formatting is correct? (go fmt)
• Have you checked your basic code style is fine? (golangci-lint run)
• If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
• If your changes affect the client infrastructure, have you run the integration test?
• If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
• If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
• If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Summary by CodeRabbit

• New Features

  • Enhanced end-to-end encryption (E2EE) by validating keys during registration.
  • Added a new test to ensure the robustness of the key registration process.

• Bug Fixes

  • Updated key value configuration to enhance security measures.

• Refactor

  • Implemented safer methods for accessing dictionary keys in the application's backend, enhancing stability and error management.

[coderabbitai]

Warning

Rate Limit Exceeded

@mmsqe has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 8 seconds before requesting another review.

How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.
Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.
Please see our FAQ for further information.

Commits

Files that changed from the base of the PR and between 96a5eef and 3aa9d02.

Walkthrough

The recent updates focus on enhancing the security and reliability of the e2ee module by introducing key validation during registration, refining key handling across configurations and API calls. These changes aim to strengthen encryption key management and reinforce secure access practices, ultimately bolstering the system's security posture.

Changes

File Path	Change Summary
CHANGELOG.md, keeper/keeper.go, types/msg.go	Enhanced e2ee module with key validation during registration.
integration_tests/default.jsonnet, cosmoscli.py, test_e2ee.py	Updated key formats, improved key access safety, and added key registration test.

🐇✨
In the land of code where the bits align,
A rabbit hopped, leaving changes behind.
Keys now safe, with a validation embrace,
In every byte, a secure, cozy space.
Hop, hop, hooray, to safer days! 🎉
🐇✨

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

Out of diff range and nitpick comments (3)

CHANGELOG.md (3)

Line range hint 44-44: Ensure consistent list item markers.

- - [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API.
+ * [#1363](https://github.com/crypto-org-chain/cronos/pull/1363) Update ethermint to fix a panic on overflow and patch gasUsed in the RPC API.

---

Line range hint 56-56: Ensure consistent list item markers.

- - [#1362](https://github.com/crypto-org-chain/cronos/pull/1362) Log blacklist addresses.
+ * [#1362](https://github.com/crypto-org-chain/cronos/pull/1362) Log blacklist addresses.

---

Line range hint 64-64: Ensure consistent list item markers.

- - [#1336](https://github.com/crypto-org-chain/cronos/pull/1336) Update ethermint to develop to fix feeHistory rpc api.
+ * [#1336](https://github.com/crypto-org-chain/cronos/pull/1336) Update ethermint to develop to fix feeHistory rpc api.

[codecov]

Codecov Report

Attention: Patch coverage is 30.76923% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 35.84%. Comparing base (662c643) to head (3aa9d02).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1421      +/-   ##
==========================================
+ Coverage   35.80%   35.84%   +0.04%     
==========================================
  Files         136      136              
  Lines        9879     9876       -3     
==========================================
+ Hits         3537     3540       +3     
+ Misses       5945     5940       -5     
+ Partials      397      396       -1     

Files	Coverage Δ
x/e2ee/types/keys.go	22.22% <100.00%> (+4.04%)	⬆️
x/e2ee/types/msg.go	42.85% <75.00%> (+42.85%)	⬆️
x/e2ee/keeper/keeper.go	11.76% <0.00%> (ø)

[yihuang]

no need to call ValidateBasic in msg handler, otherwise, LGTM

[coderabbitai]

Actionable comments posted: 0

Out of diff range and nitpick comments (1)

x/e2ee/types/keys.go (1)

40-41: Enhance encryption key validation.

Consider adding a comment explaining the purpose and mechanism of ValidateRecipientKey for better maintainability.