Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: memiavl db in CacheMultiStoreWithVersion not closed #1151

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Sep 4, 2023

Solution:

  • add a wrapper that supports io.Closer

Impact:

  • this PR only adds a Closer method to it, but not call it, for example, sdk grpc query service will not call it, unless patched.
  • versiondb nodes handle grpc queries without memiavl, so no problem there.
  • for other use cases that use memiavl's CacheMultiStoreWithVersion method should call the Close() method explicitly.
  • ideally we should patch sdk itself to add Close method, it's relevant to existing iavl as well.

👮🏻👮🏻👮🏻 !!!! REFERENCE THE PROBLEM YOUR ARE SOLVING IN THE PR TITLE AND DESCRIBE YOUR SOLUTION HERE !!!! DO NOT FORGET !!!! 👮🏻👮🏻👮🏻

PR Checklist:

  • Have you read the CONTRIBUTING.md?
  • Does your PR follow the C4 patch requirements?
  • Have you rebased your work on top of the latest master?
  • Have you checked your code compiles? (make)
  • Have you included tests for any non-trivial functionality?
  • Have you checked your code passes the unit tests? (make test)
  • Have you checked your code formatting is correct? (go fmt)
  • Have you checked your basic code style is fine? (golangci-lint run)
  • If you added any dependencies, have you checked they do not contain any known vulnerabilities? (go list -json -m all | nancy sleuth)
  • If your changes affect the client infrastructure, have you run the integration test?
  • If your changes affect public APIs, does your PR follow the C4 evolution of public contracts?
  • If your code changes public APIs, have you incremented the crate version numbers and documented your changes in the CHANGELOG.md?
  • If you are contributing for the first time, please read the agreement in CONTRIBUTING.md now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thank you for your code, it's appreciated! :)

Solution:
- add a wrapper that supports io.Closer

Impact:
- this PR only adds a Closer method to it, but not call it,
  for example, sdk grpc query service will not call it, unless patched.
- versiondb nodes handle grpc queries without memiavl, so no problem there.
- for other use cases that use memiavl's `CacheMultiStoreWithVersion` method
  should call the `Close()` method explicitly.
@yihuang yihuang requested a review from a team as a code owner September 4, 2023 01:15
@yihuang yihuang requested review from calvinaco and thomas-nguy and removed request for a team September 4, 2023 01:15
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: yihuang <[email protected]>
@yihuang yihuang requested a review from mmsqe September 4, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants