Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: memiavl db in CacheMultiStoreWithVersion not closed #1151

Merged
merged 2 commits into from
Sep 4, 2023
Merged

Problem: memiavl db in CacheMultiStoreWithVersion not closed #1151

merged 2 commits into from
Sep 4, 2023

Commits on Sep 4, 2023

  1. Problem: memiavl db in CacheMultiStoreWithVersion not closed 

    Solution:
- add a wrapper that supports io.Closer

Impact:
- this PR only adds a Closer method to it, but not call it,
  for example, sdk grpc query service will not call it, unless patched.
- versiondb nodes handle grpc queries without memiavl, so no problem there.
- for other use cases that use memiavl's `CacheMultiStoreWithVersion` method
  should call the `Close()` method explicitly.
    @yihuang
    yihuang committed Sep 4, 2023
    Configuration menu
    Copy the full SHA
    83cd34a View commit details
    Browse the repository at this point in the history

  2. Update CHANGELOG.md 

    Signed-off-by: yihuang <[email protected]>
    @yihuang
    yihuang authored Sep 4, 2023
    Configuration menu
    Copy the full SHA
    e327f0a View commit details
    Browse the repository at this point in the history