Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem: v0.52.x is outdated #1155

Open
wants to merge 74 commits into
base: release/v0.52.x
Choose a base branch
from
Open

Problem: v0.52.x is outdated #1155

wants to merge 74 commits into from
+12,750 −8,294

Conversation

mmsqe
Copy link
Collaborator

@mmsqe mmsqe commented Jan 9, 2025 •
edited
Loading

Description

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

mergify bot and others added 30 commits December 11, 2024 17:15
@mergify @hieuvubk @julienrbrt
refactor(server/v2/cometbft): Handle non-module service queries (back…
d6d1777 
…port cosmos#22803) (cosmos#22834)

Co-authored-by: Hieu Vu <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
test(systemtest): fix cometbft client (backport cosmos#22835) (cosmos…
25d0b70 
…#22836)

Co-authored-by: Julien Robert <[email protected]>
@robert-zaremba @julienrbrt
build(deps): fix x/protocolpool version in x/feegrant (cosmos#22839)
aa32fa0 
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
fix(stf,server/v2/cometbft): fix default events + improve codec handl…
af4ecd9 
…ing (backport cosmos#22837) (cosmos#22848)

Co-authored-by: Julien Robert <[email protected]>
@mergify @kocubinski @julienrbrt
feat(tools/benchmark): introduce benchmark module (backport cosmos#22778
1fbc003 
) (cosmos#22851)

Co-authored-by: Matt Kocubinski <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
chore: sync changelog to main + clean-up replaces (backport cosmos#22846
b740c7f 
) (cosmos#22860)

Co-authored-by: Julien Robert <[email protected]>
@sontrinh16
chore: Using context.Context in x/staking and testutil test helper (c…
eac97c9 
…osmos#22861)
@akhilkumarpilli
chore: backport x/staking integration test migration changes (cosmos#…
a643d3a 
…22863)
@mergify @testinginprod
fix(baseapp): hybrid handlers do not drop any (backport cosmos#22866) (…
f1e881e 
…cosmos#22868)

Co-authored-by: testinginprod <[email protected]>
@mergify
refactor(client/v2): remove gov dependency (backport cosmos#22867) (c…
2e15f67 
…osmos#22869)
@mergify
docs: fix spelling errors in the description (backport cosmos#22874) (c…
b6441e0 
…osmos#22879)
@mergify @lilasxie
docs: correct Continous spelling to Continuous (backport cosmos#2…
356ca4e 
…2880) (cosmos#22882)

Co-authored-by: lilasxie <[email protected]>
@mergify @julienrbrt
chore: package release prep + update UPGRADING.md (backport cosmos#22864
854c024 
) (cosmos#22883)

Co-authored-by: Julien Robert <[email protected]>
@mergify @tac0turtle @julienrbrt
refactor(x/staking)!: removing unbonding queue index (backport cosmos…
0a18aca 
…#22795) (cosmos#22886)

Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @mmsqe
fix(test): avoid concurrent read and write on same hash in oe test (b…
98393be 
…ackport cosmos#22892) (cosmos#22894)

Co-authored-by: mmsqe <[email protected]>
@alpe
Merge commit from fork
8969116 
* Limit recursion depth for unknown field detection

* Limit unpack any

* Update changelog

* Another limit recursion depth for unknown field detection

* Remove x/tx files
@mergify @github-actions @tac0turtle
chore: fix spelling errors (backport cosmos#22888) (cosmos#22899)
9b38363 
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: marbar3778 <[email protected]>
@mergify
test: fix failing tests after protocompat changes (backport cosmos#22889
9065da9 
) (cosmos#22897)
@mergify @aljo242
refactor(x/validate): add nil protection (backport cosmos#22902) (c…
50ba3c9 
…osmos#22909)

Co-authored-by: Alex | Skip <[email protected]>
@mergify @julienrbrt
chore: package release prep (2/n) (backport cosmos#22885) (cosmos#22910)
3104dd1 
Co-authored-by: Julien Robert <[email protected]>
@dependabot @julienrbrt
build(deps): Bump github.com/cosmos/iavl from 1.3.2 to 1.3.3 (cosmos#…
bf4f3c7 
…22920)

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
chore: re-add IntProto and DecProto and deprecate msg (backport cosmo…
6634711 
…s#22925) (cosmos#22928)

Co-authored-by: Julien Robert <[email protected]>
@mergify @sontrinh16 @julienrbrt
fix(x/accounts/default/lockup): Lockup account track undelegation whe…
b6fa674 
…n unbonding entry is mature (backport cosmos#22254) (cosmos#22930)

Co-authored-by: son trinh <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify
chore: fix docs links (backport cosmos#22931) (cosmos#22933)
335697d
@mergify @julienrbrt
refactor: limit breaking changes for next version (backport cosmos#22972
61390f6 
) (cosmos#22974)

Co-authored-by: Julien Robert <[email protected]>
@mergify @julienrbrt
chore: package release prep (3/n) (backport cosmos#22929) (cosmos#22971)
182dc41 
Co-authored-by: Julien Robert <[email protected]>
@julienrbrt
sync with main
fa8ce1e
@mergify @tac0turtle @julienrbrt
refactor(x/mint): remove staking as a required module (backport cosmo…
221b8ab 
…s#21858) (cosmos#22979)

Co-authored-by: Marko <[email protected]>
Co-authored-by: Julien Robert <[email protected]>
@mergify @JulianToledano
feat(client/v2): support definitions of inner messages (backport cosm…
4740902 
…os#22890) (cosmos#22980)

Co-authored-by: Julián Toledano <[email protected]>
@julienrbrt
chore: the great replace removal (release/v0.52.x) (1/3) (cosmos#22977)
98acf3a
@mmsqe mmsqe changed the title Release/v0.52.x sync Problem: v0.52.x is outdated Jan 9, 2025
@mmsqe mmsqe requested a review from yihuang January 9, 2025 04:35
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 9, 2025
View reviewed changes
tools/benchmark/client/cli/tx.go
cmd.Printf(
"success_tx=%d err_tx=%d seq=%d rate=%.2f/s overall=%.2f/s\n",
successCount, errCount, accSeq,
float64(successCount-last)/time.Since(since).Seconds(),

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/client/cli/tx.go
"success_tx=%d err_tx=%d seq=%d rate=%.2f/s overall=%.2f/s\n",
successCount, errCount, accSeq,
float64(successCount-last)/time.Since(since).Seconds(),
float64(successCount)/time.Since(begin).Seconds(),

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go
// The operation is one of insert, update, get, or delete.
// The tx client calls this function to deterministically generate the next operation.
func (g *Generator) Next() (uint64, *benchmark.Op, error) {
if g.InsertWeight+g.UpdateWeight+g.GetWeight+g.DeleteWeight != 1 {

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go
// The operation is one of insert, update, get, or delete.
// The tx client calls this function to deterministically generate the next operation.
func (g *Generator) Next() (uint64, *benchmark.Op, error) {
if g.InsertWeight+g.UpdateWeight+g.GetWeight+g.DeleteWeight != 1 {

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go
// The operation is one of insert, update, get, or delete.
// The tx client calls this function to deterministically generate the next operation.
func (g *Generator) Next() (uint64, *benchmark.Op, error) {
if g.InsertWeight+g.UpdateWeight+g.GetWeight+g.DeleteWeight != 1 {

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go
op.Seed = key.Seed()
op.KeyLength = key.Length()
op.ValueLength = g.getLength(g.ValueMean, g.ValueStdDev)
case x < g.InsertWeight+g.UpdateWeight+g.GetWeight:

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go
op.Seed = key.Seed()
op.KeyLength = key.Length()
op.ValueLength = g.getLength(g.ValueMean, g.ValueStdDev)
case x < g.InsertWeight+g.UpdateWeight+g.GetWeight:

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go

// NormUint64 returns a random uint64 with a normal distribution.
func (g *Generator) NormUint64(mean, stdDev uint64) uint64 {
return uint64(g.rand.NormFloat64()*float64(stdDev) + float64(mean))

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/generator/gen.go

// NormUint64 returns a random uint64 with a normal distribution.
func (g *Generator) NormUint64(mean, stdDev uint64) uint64 {
return uint64(g.rand.NormFloat64()*float64(stdDev) + float64(mean))

Check notice

Code scanning / CodeQL

Floating point arithmetic Note test

Floating point arithmetic operations are not associative and a possible source of non-determinism
tools/benchmark/module/depinject.go
package module

import (
"unsafe"

Check notice

Code scanning / CodeQL

Sensitive package import Note test

Certain system packages contain functions which may be a possible source of non-determinism
@mmsqe
Revert "keep 1.23.3"
128760e 
This reverts commit 17358a9.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yihuang yihuang Awaiting requested review from yihuang

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
C:CLI C:Confix C:server/v2 cometbft C:server/v2 C:Simulations C:x/accounts/base C:x/accounts/lockup C:x/accounts/multisig C:x/accounts C:x/auth C:x/authz C:x/bank C:x/circuit C:x/consensus C:x/distribution C:x/epochs C:x/evidence C:x/feegrant C:x/gov C:x/group C:x/mint C:x/nft C:x/params C:x/protocolpool C:x/slashing C:x/staking C:x/upgrade C:x/validate Type: ADR Type: Build Type: CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mmsqe @robert-zaremba @sontrinh16 @akhilkumarpilli @alpe @julienrbrt @kocubinski