Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: correct Continous spelling to Continuous #22880

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

lilasxie
Copy link
Contributor

@lilasxie lilasxie commented Dec 16, 2024

Summary by CodeRabbit

  • Bug Fixes
    • Corrected spelling of "Continuous" in multiple test function names for improved clarity.
    • Updated method signatures to reflect the correct spelling in the test setup and related functions.

Copy link
Contributor

coderabbitai bot commented Dec 16, 2024

📝 Walkthrough

Walkthrough

The pull request focuses on correcting spelling in the continuous_locking_account_test.go file. Multiple function names containing the misspelled word "Continous" have been updated to the correct spelling "Continuous". This includes the setup function and several test functions. The changes are purely cosmetic and do not alter the underlying test logic or functionality.

Changes

File Changes
x/accounts/defaults/lockup/continuous_locking_account_test.go - Renamed setupContinousAccount to setupContinuousAccount
- Corrected spelling in test function names:
* TestContinousAccountDelegateTestContinuousAccountDelegate
* TestContinousAccountUndelegateTestContinuousAccountUndelegate
* TestContinousAccountSendCoinsTestContinuousAccountSendCoins
* TestContinousAccountWithdrawUnlockedCoinsTestContinuousAccountWithdrawUnlockedCoins
* TestContinousAccountGetLockCoinInfoTestContinuousAccountGetLockCoinInfo

Note: No sequence diagram is generated as these are purely naming corrections without changes to the underlying functionality.

Tip

CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command @coderabbitai generate docstrings to have CodeRabbit automatically generate docstrings for your pull request.


📜 Recent review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6500a72 and 186c1f7.

📒 Files selected for processing (1)
  • x/accounts/defaults/lockup/continuous_locking_account_test.go (6 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
x/accounts/defaults/lockup/continuous_locking_account_test.go (2)

Pattern **/*.go: Review the Golang code for conformity with the Uber Golang style guide, highlighting any deviations.


Pattern **/*_test.go: "Assess the unit test code assessing sufficient code coverage for the changes associated in the pull request"

🔇 Additional comments (7)
x/accounts/defaults/lockup/continuous_locking_account_test.go (7)

19-19: LGTM: Spelling correction implemented correctly

The helper function has been properly renamed from "setupContinousAccount" to "setupContinuousAccount". The function follows Go test helper best practices with t.Helper().


36-36: LGTM: Test function renamed correctly

The test function has been properly renamed from "TestContinousAccountDelegate" to "TestContinuousAccountDelegate". The helper function call has also been updated consistently.

Also applies to: 42-42


78-78: LGTM: Test function renamed correctly

The test function has been properly renamed from "TestContinousAccountUndelegate" to "TestContinuousAccountUndelegate". The helper function call has also been updated consistently.

Also applies to: 84-84


149-149: LGTM: Test function renamed correctly

The test function has been properly renamed from "TestContinousAccountSendCoins" to "TestContinuousAccountSendCoins". The helper function call has also been updated consistently.

Also applies to: 155-155


179-179: LGTM: Test function renamed correctly

The test function has been properly renamed from "TestContinousAccountWithdrawUnlockedCoins" to "TestContinuousAccountWithdrawUnlockedCoins". The helper function call has also been updated consistently.

Also applies to: 185-185


Line range hint 19-215: Overall assessment: All spelling corrections implemented correctly

All instances of "Continous" have been properly corrected to "Continuous" throughout the test file. The changes are purely cosmetic and maintain:

  • Complete test coverage
  • Consistent function naming
  • Proper test helper usage

209-209: LGTM: Test function renamed correctly

The test function has been properly renamed from "TestContinousAccountGetLockCoinInfo" to "TestContinuousAccountGetLockCoinInfo". The helper function call has also been updated consistently.

Let's verify that all references to the old spelling have been updated:

Also applies to: 215-215

✅ Verification successful

Let's verify both spellings to ensure we have a complete picture of the changes.


LGTM: All references to the test function have been updated correctly

The search results confirm that there are no remaining instances of the misspelled "Continous" in the codebase. The test function rename from "TestContinousAccountGetLockCoinInfo" to "TestContinuousAccountGetLockCoinInfo" is consistent with the rest of the codebase, which uses the correct spelling "Continuous" throughout.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for any remaining instances of "Continous" in the codebase
rg "Continous" --type go

Length of output: 24


Script:

#!/bin/bash
# Search for any remaining instances of "Continous" with case-insensitive flag
rg -i "continous" --type go

# Also search for the correct spelling to verify the rename
rg -i "continuous" --type go

Length of output: 74009


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Dec 16, 2024
@julienrbrt julienrbrt enabled auto-merge December 16, 2024 08:33
@julienrbrt julienrbrt added this pull request to the merge queue Dec 16, 2024
Merged via the queue into cosmos:main with commit 5761530 Dec 16, 2024
73 of 80 checks passed
mergify bot pushed a commit that referenced this pull request Dec 16, 2024
julienrbrt pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release C:x/accounts/lockup C:x/accounts
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants