Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix docs links #22931

Merged
merged 3 commits into from
Dec 17, 2024
Merged

chore: fix docs links #22931

merged 3 commits into from
Dec 17, 2024

Conversation

ayenesimo1i
Copy link
Contributor

@ayenesimo1i ayenesimo1i commented Dec 17, 2024

fixed a few references to re-named sections in BaseApp in docs

Summary by CodeRabbit

  • Documentation
    • Updated the Module Manager documentation to clarify routing terminology and interface roles.
    • Enhanced the 00-app-anatomy.md document for better understanding of Cosmos SDK application structure and functionality.
    • Revised the 03-sdk-design.md document to reflect changes in the description of the router component.

@ayenesimo1i ayenesimo1i requested a review from a team as a code owner December 17, 2024 16:35
Copy link
Contributor

coderabbitai bot commented Dec 17, 2024

📝 Walkthrough

Walkthrough

The pull request involves documentation updates for the Cosmos SDK, focusing on three key documents: module manager documentation, application anatomy, and SDK design. The changes primarily enhance clarity around terminology, particularly replacing "message and query routing" with "service routers". The documentation updates provide more detailed explanations of application components, initialization processes, and module interfaces, aiming to improve developer understanding of the SDK's architecture and functionality.

Changes

File Change Summary
docs/build/building-modules/01-module-manager.md Updated terminology from "message and query routing" to "service routers", clarified AppModule interface details, and emphasized selective interface implementation
docs/learn/beginner/00-app-anatomy.md Enhanced explanations of node client, core application file, constructor function, lifecycle methods, and added EncodingConfig structure description
docs/learn/intro/03-sdk-design.md Updated router reference link from #routing to #service-routers

Suggested Labels

C:x/staking, C:Simulations, backport/v0.52.x

Suggested Reviewers

  • julienrbrt
  • akhilkumarpilli
  • facundomedica
  • tac0turtle

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
docs/build/building-modules/01-module-manager.md (1)

8-8: Improve readability by refining the wording.

Consider these improvements:

  • Replace "in order to" with "to"
  • Replace "a variety of functions" with "functions"
-Cosmos SDK modules need to implement the [`AppModule` interfaces](#application-module-interfaces), in order to be managed by the application's [module manager](#module-manager). The module manager plays an important role in [`message` and `query` routing](../../learn/advanced/00-baseapp.md#service-routers), and allows application developers to set the order of execution of a variety of functions like [`PreBlocker`, `BeginBlocker` and `EndBlocker`](https://docs.cosmos.network/main/learn/beginner/app-anatomy).
+Cosmos SDK modules need to implement the [`AppModule` interfaces](#application-module-interfaces) to be managed by the application's [module manager](#module-manager). The module manager plays an important role in [`message` and `query` routing](../../learn/advanced/00-baseapp.md#service-routers), and allows application developers to set the order of execution of functions like [`PreBlocker`, `BeginBlocker` and `EndBlocker`](https://docs.cosmos.network/main/learn/beginner/app-anatomy).
🧰 Tools
🪛 LanguageTool

[style] ~8-~8: Consider a shorter alternative to avoid wordiness.
Context: ...faces](#application-module-interfaces), in order to be managed by the application's [module...

(IN_ORDER_TO_PREMIUM)


[style] ~8-~8: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...lopers to set the order of execution of a variety of functions like [PreBlocker, `BeginBlo...

(A_VARIETY_OF)

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between def23f0 and 0a87bf9.

📒 Files selected for processing (3)
  • docs/build/building-modules/01-module-manager.md (1 hunks)
  • docs/learn/beginner/00-app-anatomy.md (1 hunks)
  • docs/learn/intro/03-sdk-design.md (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • docs/learn/intro/03-sdk-design.md
🧰 Additional context used
📓 Path-based instructions (2)
docs/build/building-modules/01-module-manager.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/learn/beginner/00-app-anatomy.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/build/building-modules/01-module-manager.md

[style] ~8-~8: Consider a shorter alternative to avoid wordiness.
Context: ...faces](#application-module-interfaces), in order to be managed by the application's [module...

(IN_ORDER_TO_PREMIUM)


[style] ~8-~8: The phrase “a variety of” may be wordy. To make your writing clearer, consider replacing it.
Context: ...lopers to set the order of execution of a variety of functions like [PreBlocker, `BeginBlo...

(A_VARIETY_OF)

🔇 Additional comments (1)
docs/learn/beginner/00-app-anatomy.md (1)

89-89: LGTM!

The documentation correctly references the updated terminology of "service routers" and provides clear explanations of the routing mechanisms.

@julienrbrt julienrbrt added the backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release label Dec 17, 2024
Copy link
Member

@julienrbrt julienrbrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tac0turtle tac0turtle added this pull request to the merge queue Dec 17, 2024
Merged via the queue into cosmos:main with commit 36a846c Dec 17, 2024
73 of 77 checks passed
mergify bot pushed a commit that referenced this pull request Dec 17, 2024
(cherry picked from commit 36a846c)
julienrbrt pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/v0.52.x PR scheduled for inclusion in the v0.52's next stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants