Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix spelling errors #23038

Merged
merged 4 commits into from
Dec 20, 2024
Merged

docs: fix spelling errors #23038

merged 4 commits into from
Dec 20, 2024

Conversation

osrm
Copy link
Contributor

@osrm osrm commented Dec 20, 2024

Description

I've checked every ‘md’ files in the repository and found some typos that needed to be fixed because they clearly changed the meaning and fixed them.

There were also some awkward wording and punctuation, but I didn't fix those because they don't detract too much from the meaning of the original documentation and don't cause any problems in understanding the documentation.

The commit explains which typos are fixed. Hope this helps.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title, you can find examples of the prefixes below:
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

Please see Pull Request Reviewer section in the contributing guide for more information on how to review a pull request.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

Summary by CodeRabbit

  • Documentation

    • Enhanced clarity and instructions for running a blockchain node.
    • Updated naming conventions and versioning strategies for Protocol Buffers.
    • Proposed a new core API to improve simplicity and extensibility within the Cosmos SDK.
  • Bug Fixes

    • Corrected typographical errors in documentation.
  • Chores

    • Added new sections for managing snapshots and local state sync in the node running guide.

osrm added 3 commits December 20, 2024 18:41
"Bootsrapping" -> "Bootstrapping"
"ServiceRegitrar" -> "ServiceRegistrar"
"fully-qualifed" -> "fully-qualified"
@osrm osrm requested a review from a team as a code owner December 20, 2024 11:39
Copy link
Contributor

coderabbitai bot commented Dec 20, 2024

📝 Walkthrough

Walkthrough

The pull request encompasses documentation updates focusing on two key architectural decision records (ADRs) and a user guide for running nodes. The first ADR (adr-023-protobuf-naming.md) refines Protocol Buffers naming conventions, emphasizing clarity, versioning strategies, and package naming principles. The second ADR (adr-063-core-module-api.md) proposes a comprehensive redesign of the core module API to enhance simplicity, extensibility, and stability in cosmos-sdk applications. The user guide (01-run-node.md) receives updates to improve node running instructions and configuration clarity.

Changes

File Change Summary
docs/architecture/adr-023-protobuf-naming.md - Corrected typo from "fully-qualifed" to "fully-qualified"
- Enhanced guidelines for Protocol Buffers naming conventions
- Expanded versioning strategies and package naming principles
docs/architecture/adr-063-core-module-api.md - Introduced new core API interfaces for store, event, and module services
- Proposed replacement for existing AppModule and sdk.Context frameworks
- Outlined runtime compatibility and versioning approach
docs/user/run-node/01-run-node.md - Added prerequisites and initialization instructions
- Expanded configuration file explanations
- Updated client interaction and node running guidance
- Added new sections on logging and snapshots

Sequence Diagram

sequenceDiagram
    participant Module as Application Module
    participant CoreAPI as Core API Services
    participant Store as Store Service
    participant Event as Event Service

    Module->>CoreAPI: Register Services
    CoreAPI->>Store: Open KV Store
    CoreAPI->>Event: Emit Events
    Module->>CoreAPI: Perform Genesis Operations
    CoreAPI->>Module: Provide Context and Services
Loading

Possibly related PRs

Suggested Reviewers

  • julienrbrt
  • sontrinh16
  • akhilkumarpilli

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (3)
docs/user/run-node/01-run-node.md (1)

201-201: Improve sentence structure for clarity

The sentence can be simplified to improve readability.

-3. Bootstrapping Comet state in order to start the node after the snapshot has been ingested.
+3. Bootstrap Comet state to start the node after ingesting the snapshot.
🧰 Tools
🪛 LanguageTool

[style] ~201-~201: Consider a shorter alternative to avoid wordiness.
Context: ...command). 3. Bootstrapping Comet state in order to start the node after the snapshot has b...

(IN_ORDER_TO_PREMIUM)

docs/architecture/adr-023-protobuf-naming.md (1)

73-73: Fix punctuation and hyphenation

There are two minor issues in this sentence:

  1. Missing comma after "names"
  2. Unnecessary hyphen in "fully-qualified" as "fully" is an adverb ending in 'ly'
-Given that we are using fully-qualified names within
+Given that we are using fully qualified names, within
🧰 Tools
🪛 LanguageTool

[uncategorized] ~73-~73: Possible missing comma found.
Context: ...stinguish them from other names. Given that we are using fully-qualified names with...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~73-~73: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...m other names. Given that we are using fully-qualified names within google.protobuf.Any as w...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

docs/architecture/adr-063-core-module-api.md (1)

229-229: Add explanation for the protobuf option

The mention of cosmos.msg.v1.service protobuf option would benefit from a brief explanation of its purpose and why it's required for Msg services.

Consider adding a brief explanation like:
"The cosmos.msg.v1.service protobuf option is required for Msg services as it enables proper message routing and handling within the Cosmos SDK framework."

📜 Review details

Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b2c39e2 and 024909f.

📒 Files selected for processing (3)
  • docs/architecture/adr-023-protobuf-naming.md (1 hunks)
  • docs/architecture/adr-063-core-module-api.md (1 hunks)
  • docs/user/run-node/01-run-node.md (1 hunks)
🧰 Additional context used
📓 Path-based instructions (3)
docs/architecture/adr-023-protobuf-naming.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/user/run-node/01-run-node.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

docs/architecture/adr-063-core-module-api.md (1)

Pattern **/*.md: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"

🪛 LanguageTool
docs/architecture/adr-023-protobuf-naming.md

[uncategorized] ~73-~73: Possible missing comma found.
Context: ...stinguish them from other names. Given that we are using fully-qualified names with...

(AI_HYDRA_LEO_MISSING_COMMA)


[uncategorized] ~73-~73: Although a hyphen is possible, it is not necessary in a compound modifier in which the first word is an adverb that ends in ‘ly’.
Context: ...m other names. Given that we are using fully-qualified names within google.protobuf.Any as w...

(HYPHENATED_LY_ADVERB_ADJECTIVE)

docs/user/run-node/01-run-node.md

[style] ~201-~201: Consider a shorter alternative to avoid wordiness.
Context: ...command). 3. Bootstrapping Comet state in order to start the node after the snapshot has b...

(IN_ORDER_TO_PREMIUM)

@tac0turtle tac0turtle enabled auto-merge December 20, 2024 13:46
@tac0turtle tac0turtle added this pull request to the merge queue Dec 20, 2024
Merged via the queue into cosmos:main with commit 6ed9452 Dec 20, 2024
71 of 73 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants