-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: remove redundant words and symbols #23058
base: main
Are you sure you want to change the base?
Conversation
📝 WalkthroughWalkthroughThe pull request documents architectural changes in the Cosmos SDK version 2 (V2), focusing on a comprehensive rewrite to enhance modularity and extensibility. The documentation outlines a significant restructuring of the SDK's core components, introducing a more flexible approach to building blockchain applications. Key areas of focus include the State Transition Function, Consensus component, and changes to handling vote extensions, emphasizing a modular design that allows developers to select only necessary components for their specific application needs. Changes
Sequence DiagramsequenceDiagram
participant App as Application
participant STF as State Transition Function
participant Consensus as Consensus Engine
participant Store as Store/v2
App->>STF: Execute Transaction
STF->>Store: Perform State Changes
STF->>Consensus: Commit State
Consensus-->>App: Validate and Confirm
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (4)
docs/architecture/adr-75-v2.md (2)
107-107
: Add comma for better readabilityAdd a comma after "swapped" to separate independent clauses:
-Since consensus servers can be swapped there are certain features specific to consensus engines need to be implemented in the server. +Since consensus servers can be swapped, there are certain features specific to consensus engines need to be implemented in the server.🧰 Tools
🪛 LanguageTool
[typographical] ~107-~107: Consider adding a comma.
Context: ... Since consensus servers can be swapped there are certain features specific to consen...(IF_THERE_COMMA)
[uncategorized] ~107-~107: Possible missing comma found.
Context: ...lemented in the server. In the CometBFT server we have implemented the following featu...(AI_HYDRA_LEO_MISSING_COMMA)
Line range hint
1-24
: Remove redundant phrases in introductionSimplify the following phrases:
- "V2 is a reset in the Cosmos SDK architecture. It is a complete rewrite of the SDK" -> "V2 is a complete rewrite of the Cosmos SDK architecture"
- "with a focus on modularity, extensibility, and performance" appears twice in close proximity
🧰 Tools
🪛 LanguageTool
[typographical] ~107-~107: Consider adding a comma.
Context: ... Since consensus servers can be swapped there are certain features specific to consen...(IF_THERE_COMMA)
[uncategorized] ~107-~107: Possible missing comma found.
Context: ...lemented in the server. In the CometBFT server we have implemented the following featu...(AI_HYDRA_LEO_MISSING_COMMA)
docs/build/abci/03-vote-extensions.md (2)
Line range hint
150-156
: Simplify handler explanationThe explanation "Same as above" can be more specific:
-Same as above: +Similar to ExtendVoteHandler, VerifyVoteExtensionHandler is passed as a server option:
271-271
: Remove redundant transition phraseThe phrase "However, it is" is redundant and can be removed:
-In v2, the `PreBlocker` function works in the same way as it does in v1. However, it is now passed in as an option to `appbuilder.Build`. +In v2, the `PreBlocker` function works the same way as in v1 and is passed in as an option to `appbuilder.Build`.
📜 Review details
Configuration used: .coderabbit.yml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/architecture/adr-75-v2.md
(1 hunks)docs/build/abci/03-vote-extensions.md
(2 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
docs/architecture/adr-75-v2.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
docs/build/abci/03-vote-extensions.md (1)
Pattern **/*.md
: "Assess the documentation for misspellings, grammatical errors, missing documentation and correctness"
🪛 LanguageTool
docs/architecture/adr-75-v2.md
[typographical] ~107-~107: Consider adding a comma.
Context: ... Since consensus servers can be swapped there are certain features specific to consen...
(IF_THERE_COMMA)
[uncategorized] ~107-~107: Possible missing comma found.
Context: ...lemented in the server. In the CometBFT server we have implemented the following featu...
(AI_HYDRA_LEO_MISSING_COMMA)
Summary by CodeRabbit