Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: latest pre-release of Cosmos SDK not used #502

Closed
wants to merge 12 commits into from

Conversation

tomtau
Copy link
Contributor

@tomtau tomtau commented Apr 26, 2021

Solution: bumped the SDK version to v0.43.0-alpha1

  • added ibc-go (the IBC modules were moved out of Cosmos SDK)
  • code adjusted according to the other breaking API changes

Solution: bumped the SDK version to v0.43.0-alpha1
+ added ibc-go (the IBC modules were moved out of Cosmos SDK)
+ code adjusted according to the other breaking API changes
@codecov
Copy link

codecov bot commented Apr 26, 2021

Codecov Report

Merging #502 (7b7d28c) into master (3efdaeb) will decrease coverage by 1.09%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #502      +/-   ##
=========================================
- Coverage    2.77%   1.68%   -1.10%     
=========================================
  Files           6       6              
  Lines         216     356     +140     
=========================================
  Hits            6       6              
- Misses        206     349     +143     
+ Partials        4       1       -3     
Flag Coverage Δ
unit_tests 1.68% <0.00%> (-1.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
app/app.go 1.44% <0.00%> (+0.66%) ⬆️
app/test_helpers.go 0.00% <0.00%> (ø)
config/config.go 66.66% <ø> (+11.11%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3efdaeb...7b7d28c. Read the comment docs.

@tomtau
Copy link
Contributor Author

tomtau commented Apr 26, 2021

@yihuang seems one may need to add --home ... to all/most of the raw calls in integration tests?

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Apr 27, 2021

i'm checking test_basic.py
default output changed to yaml
using pipe?
yq eval -j

or directly converting yaml text to json object?
json.loads -> yaml.load

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Apr 27, 2021

add broadcast_mode like this

       a=self.raw(
                "tx",
                "bank",
                "send",
                from_,
                to,
                coins,
                "-y",
                "--generate-only" if generate_only else None,
                home=self.data_dir,
                keyring_backend="test",
                chain_id=self.chain_id,
                node=self.node_rpc,
                fees=fees,
                broadcast_mode="block"
        )

also json files changed, so assert errors

@leejw51crypto
Copy link
Contributor

fixing other integration tests as well

tidy up

tidy up

remove debugging

tidy up

fix test_basic

tidy up

tidy up

remove debugging

tidy up

fix multisig

join validator works
@yihuang
Copy link
Collaborator

yihuang commented Apr 27, 2021

depend on two upstream pull requests:

@yihuang
Copy link
Collaborator

yihuang commented Apr 28, 2021

relayer:

@leejw51crypto
Copy link
Contributor

leejw51crypto commented Apr 28, 2021

fixing test_grpc done,

now test_ibc left to be fixed

@yihuang
Copy link
Collaborator

yihuang commented Apr 28, 2021

fixing test_grpc done,

now test_ibc left to be fixed

in ci, there still one grpc test failure:

[gw1] [ 85%] ERROR ../../../../../nix/store/gpcr21dmzl7mda3c4m5bvlyjyha1b7k8-source/integration_tests/test_grpc.py::test_tx_broadcast 

@tomtau
Copy link
Contributor Author

tomtau commented Apr 28, 2021

closing this PR as there are too many breaking changes + the relayer may need to be upgraded + some upstream bugs (re-)emerged -- the branch will be kept for the future reference when porting to 0.43 is attempted again

@tomtau tomtau closed this Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants