-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem: latest pre-release of Cosmos SDK not used #502
Conversation
Solution: bumped the SDK version to v0.43.0-alpha1 + added ibc-go (the IBC modules were moved out of Cosmos SDK) + code adjusted according to the other breaking API changes
Codecov Report
@@ Coverage Diff @@
## master #502 +/- ##
=========================================
- Coverage 2.77% 1.68% -1.10%
=========================================
Files 6 6
Lines 216 356 +140
=========================================
Hits 6 6
- Misses 206 349 +143
+ Partials 4 1 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@yihuang seems one may need to add |
i'm checking test_basic.py or directly converting yaml text to json object? |
add broadcast_mode like this
also json files changed, so assert errors |
fixing other integration tests as well |
tidy up tidy up remove debugging tidy up fix test_basic tidy up tidy up remove debugging tidy up fix multisig join validator works
dd88d0b
to
4560356
Compare
depend on two upstream pull requests:
|
relayer:
|
fixing test_grpc done, now test_ibc left to be fixed |
in ci, there still one grpc test failure:
|
closing this PR as there are too many breaking changes + the relayer may need to be upgraded + some upstream bugs (re-)emerged -- the branch will be kept for the future reference when porting to 0.43 is attempted again |
Solution: bumped the SDK version to v0.43.0-alpha1