-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix validator address prefix #9212
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9212 +/- ##
==========================================
- Coverage 59.95% 59.86% -0.10%
==========================================
Files 595 595
Lines 37357 37355 -2
==========================================
- Hits 22397 22361 -36
- Misses 12974 13011 +37
+ Partials 1986 1983 -3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Could you add a changelog entry?
@yihuang Just to confirm, this is not state/consensus-breaking, right (for non-hub chains)?
I think it just fix a bug bring in by recent version v0.43.0-alpha1, for non-hub chains, it causes "CONSENSUS ERROR!!!". So I guess it is a consensus breaking change. I checked that the bug is not there in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for the contribution
Co-authored-by: Marko <[email protected]> (cherry picked from commit c94e9eb) # Conflicts: # x/staking/keeper/val_state_change.go
Description
staking keeper use
sdk.Bech32PrefixValAddr
directly, should usesdk.GetConfig().GetBech32ValidatorAddrPrefix()
.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes