Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix validator address prefix #9212

Merged
merged 3 commits into from
Apr 29, 2021
Merged

fix validator address prefix #9212

merged 3 commits into from
Apr 29, 2021

Conversation

yihuang
Copy link
Collaborator

@yihuang yihuang commented Apr 27, 2021

Description

staking keeper use sdk.Bech32PrefixValAddr directly, should use sdk.GetConfig().GetBech32ValidatorAddrPrefix().

closes: #XXXX


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #9212 (87c85f8) into master (0cbed20) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

❗ Current head 87c85f8 differs from pull request most recent head dd0e5bc. Consider uploading reports for the commit dd0e5bc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9212      +/-   ##
==========================================
- Coverage   59.95%   59.86%   -0.10%     
==========================================
  Files         595      595              
  Lines       37357    37355       -2     
==========================================
- Hits        22397    22361      -36     
- Misses      12974    13011      +37     
+ Partials     1986     1983       -3     
Impacted Files Coverage Δ
x/staking/keeper/val_state_change.go 51.91% <100.00%> (ø)
x/feegrant/types/msgs.go 0.00% <0.00%> (-72.10%) ⬇️
x/feegrant/types/basic_fee.go 65.00% <0.00%> (-10.00%) ⬇️
x/feegrant/client/testutil/suite.go 99.15% <0.00%> (-0.51%) ⬇️
x/feegrant/types/filtered_fee.go 0.00% <0.00%> (ø)
x/staking/keeper/keeper.go 56.66% <0.00%> (+1.49%) ⬆️

Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Could you add a changelog entry?

@yihuang Just to confirm, this is not state/consensus-breaking, right (for non-hub chains)?

@yihuang
Copy link
Collaborator Author

yihuang commented Apr 29, 2021

lgtm. Could you add a changelog entry?

@yihuang Just to confirm, this is not state/consensus-breaking, right (for non-hub chains)?

I think it just fix a bug bring in by recent version v0.43.0-alpha1, for non-hub chains, it causes "CONSENSUS ERROR!!!". So I guess it is a consensus breaking change.

I checked that the bug is not there in v0.42.4, so do we need a changelog entry if the bug is not released yet?

@cyberbono3 cyberbono3 self-requested a review April 29, 2021 04:19
Copy link
Contributor

@cyberbono3 cyberbono3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@tac0turtle tac0turtle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for the contribution

@tac0turtle tac0turtle added the A:automerge Automatically merge PR once all prerequisites pass. label Apr 29, 2021
@mergify mergify bot merged commit c94e9eb into cosmos:master Apr 29, 2021
mergify bot pushed a commit that referenced this pull request Apr 29, 2021
Co-authored-by: Marko <[email protected]>
(cherry picked from commit c94e9eb)

# Conflicts:
#	x/staking/keeper/val_state_change.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A:automerge Automatically merge PR once all prerequisites pass. C:x/staking
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants