-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix client config don't take effect #9211
Conversation
Codecov Report
@@ Coverage Diff @@
## master #9211 +/- ##
==========================================
- Coverage 60.38% 59.72% -0.66%
==========================================
Files 587 595 +8
Lines 36920 37348 +428
==========================================
+ Hits 22294 22306 +12
- Misses 12651 13060 +409
- Partials 1975 1982 +7
|
@yihuang To scope the problem, can you provide some examples please for:
You can use --home flag to set HomeDir. ReadHomeFlag checks if home flag is set. If this is a case, it updates HomeDir field of client. Context. Otherwise, it uses default HomeDir. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I reproduced the error, and this fix works. Approving.
Set keyring-backend in client.toml don't work?
Yeah, client.toml is correctly updated, but the CLI doesn't read from it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK
* fix client keyring config * fix output flag of keys commads Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit b4d1a5e) # Conflicts: # client/keys/add.go
* fix client config don't take effect (#9211) * fix client keyring config * fix output flag of keys commads Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit b4d1a5e) # Conflicts: # client/keys/add.go * Fix conflicts Co-authored-by: yihuang <[email protected]> Co-authored-by: Amaury M <[email protected]>
* fix client keyring config * fix output flag of keys commads Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Amaury <[email protected]>
* fix client config don't take effect (cosmos#9211) * fix client keyring config * fix output flag of keys commads Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: Amaury <[email protected]> (cherry picked from commit b4d1a5e) * Fix conflicts Co-authored-by: yihuang <[email protected]> Co-authored-by: Amaury M <[email protected]>
Description
keyring-backend
inclient.toml
don't work, because keyring-dir is not set properly.Solution: set keyring-dir to home by default when reading
client.toml
.client.toml
even if not pass command line flag.Solution: keep
client.toml
value if flag not passed.closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerCodecov Report
in the comment section below once CI passes