Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] cryostat repo integration test suite port #42

Open
maxcao13 opened this issue Jul 31, 2023 · 1 comment
Open

[Story] cryostat repo integration test suite port #42

maxcao13 opened this issue Jul 31, 2023 · 1 comment
Labels
chore Refactor, rename, cleanup, etc. high-priority

Comments

@maxcao13
Copy link
Member

maxcao13 commented Jul 31, 2023

There are some integration tests that have been ported directly from the cryostat repo, but are disabled that need fixing. There are some that also haven't been ported over. Here's a current status of all of them.

Emoji Name Status Fixed in PR
ApiListingIT.java passes -
- ArchivedRecordingJwtDownloadIT.java not ported
- ArchivedReportJwtDownloadIT.java not ported
- AutoRulesCleanupIT.java not ported
- AutoRulesIT.java not ported
ClientAssetsIT.java passes
- CredentialsIT.java not ported
- CredentialsV2_2IT.java not ported
CryostatTemplateIT.java passes
CustomTargetsIT.java broken
- DiscoveryIT.java not ported
DiscoveryPluginIT.java broken
- FileSystemArchivedRequestsIT.java not ported
GrafanaSetupIT.java broken
- GraphQLIT.java not ported
HealthIT.java passes ?
InterleavedExternalTargetRequestsIT.java not ported
- JmxAuthIT.java not ported
- JvmIdIT.java not ported
MessagingServerIT.java broken
NonExistentTargetIT.java passes #160
NoopAuthIT.java broken
NoopAuthV2IT.java ported #160
NotificationsUrlIT.java ported #160
- RecordingJwtDownloadIT.java not ported
- RecordingMetadataIT.java not ported
RecordingWorkflowIT.java ported #160
ReportIT.java broken
- ReportJwtDownloadIT.java not ported
RulesPostFormIT.java passes #34
RulesPostJsonIT.java passes #34
- RulesPostMultipartIT.java not ported
SnapshotIT.java ported #178
TargetEventsGetIT.java passes ?
TargetPostDeleteIT.java broken
TargetRecordingOptionsIT.java broken
TargetRecordingPatchIT.java ported #183
TargetRecordingsClientErrorIT.java broken
TargetReportIT.java broken
- TemplateJwtDownloadIT.java not ported
TemplatePostDeleteIT.java broken
UploadCertificateIT.java broken
UploadRecordingIT.java ported #150
- WrongServiceListeningOnPortIT.java not ported
@maxcao13 maxcao13 added the chore Refactor, rename, cleanup, etc. label Jul 31, 2023
@maxcao13 maxcao13 moved this to In Progress in 3.0.0 release Jul 31, 2023
@maxcao13 maxcao13 moved this from In Progress to Todo in 3.0.0 release Jul 31, 2023
@andrewazores
Copy link
Member

The old ExternalTargetsTest tests should be "modernized" by using:

  1. Agent-based discovery as in https://github.com/cryostatio/cryostat/pull/1560
  2. testcontainers, https://github.com/cryostatio/cryostat3/pull/43/files#diff-e4ebe5c2d31e7916e635efa01954e316551910c04ff1c126427b6a9a1660010cR26 as an example

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. high-priority
Projects
No open projects
Status: Todo
Development

No branches or pull requests

2 participants