feat(automated-rules): implement automated rules #34
Conversation
|
I used https://github.com/projectnessie/cel-java as the implementation for Google's CEL for java. Google's repo doesn't seem to support our use case for now: google/cel-java#68 but it seems the two projects are teaming up? google/cel-java#37 |
The Project Nessie implementation looks easier to build downstream: Gradle instead of Bazel. The only drawback is if this implementation merges into Google's, we'll have to start from scratch in terms of building it. |
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
Signed-off-by: Max Cao <[email protected]>
andrewazores
force-pushed
the
automated-rules
branch
from
28544a9 to
3c89113
Compare
|
I think the new uniqueness constraint on the ActiveRecording name isn't working as anticipated: To get this I just created a rule named |
|
Easy fix after all that I just applied myself. This might be something to refactor and deal with later, but I thought that using quarkus-quartz to handle periodic archiving could be good. This would take the place of the |
I can try fitting it here. |
|
https://quarkus.io/guides/scheduler-reference#programmatic_scheduling This might be a better link to reference. I think the part about Quartz being used for persistence of scheduled tasks makes sense - that's pretty much exactly what our archiver rules are. |
I assume the Rules represent the persistent scheduled tasks themselves and used those. |
|
Yep exactly. |
|
Quartz change looks great from a reading. |
|
It doesn't seem that archive pruning is working - I created a rule with |
Hm.. I don't see this issue, can you give me recreation instructions? |
|
I'll try it again in a few minutes, I have an integration test run on a 2.3.1 backport currently running so things are a little tied up. |
|
Okay:
{
"id": 1,
"name": "test",
"description": "",
"matchExpression": "true",
"eventSpecifier": "template=ALL,type=TARGET",
"archivalPeriodSeconds": 15,
"initialDelaySeconds": 5,
"preservedArchives": 3,
"maxAgeSeconds": 30,
"maxSizeBytes": 0,
"enabled": true,
"recordingName": "auto_test",
"archiver": true
}(I created it with the form view and then downloaded the JSON back - I think the Observe these progress notifications:
result: [
{
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"jvmId": "WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"recordings": [
{
"name": "compose_cryostat_1_auto_test_20230727T195029Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUwMjlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487430
},
{
"name": "compose_cryostat_1_auto_test_20230727T195044Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUwNDRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487445
},
{
"name": "compose_cryostat_1_auto_test_20230727T195059Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUwNTlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487460
},
{
"name": "compose_cryostat_1_auto_test_20230727T195114Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUxMTRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487475
},
{
"name": "compose_cryostat_1_auto_test_20230727T195129Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUxMjlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487490
},
{
"name": "compose_cryostat_1_auto_test_20230727T195144Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUxNDRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487504
},
{
"name": "compose_cryostat_1_auto_test_20230727T195159Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUxNTlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487520
},
{
"name": "compose_cryostat_1_auto_test_20230727T195214Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUyMTRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487535
},
{
"name": "compose_cryostat_1_auto_test_20230727T195229Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUyMjlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487550
},
{
"name": "compose_cryostat_1_auto_test_20230727T195244Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUyNDRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487565
},
{
"name": "compose_cryostat_1_auto_test_20230727T195259Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUyNTlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487580
},
{
"name": "compose_cryostat_1_auto_test_20230727T195314Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUzMTRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487595
},
{
"name": "compose_cryostat_1_auto_test_20230727T195329Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUzMjlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487609
},
{
"name": "compose_cryostat_1_auto_test_20230727T195344Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUzNDRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487625
},
{
"name": "compose_cryostat_1_auto_test_20230727T195359Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTUzNTlaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487640
},
{
"name": "compose_cryostat_1_auto_test_20230727T195414Z.jfr",
"downloadUrl": "/api/v3/download/V2VIUUN2SG9NMnFHaGc2aldpb00yZ1dJd2xlbkNyT1RBS2JlMU04LTEtND0vY29tcG9zZV9jcnlvc3RhdF8xX2F1dG9fdGVzdF8yMDIzMDcyN1QxOTU0MTRaLmpmcg",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "ALL",
"connectUrl": "lost-WeHQCvHoM2qGhg6jWioM2gWIwlenCrOTAKbe1M8-1-4=",
"rule": "test",
"template.type": "TARGET"
}
},
"size": 20971520,
"archivedTime": 1690487655
}
]
},
{
"connectUrl": "lost-Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"jvmId": "Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"recordings": [
{
"name": "quarkus-test-agent_default_20230727T195314Z.jfr",
"downloadUrl": "/api/v3/download/V2I1UmFGaG1GY0IxTHlLdG41dzk0MEV0Q09BbDgydzJLQS0yUTZwUzVZZz0vcXVhcmt1cy10ZXN0LWFnZW50X2RlZmF1bHRfMjAyMzA3MjdUMTk1MzE0Wi5qZnI",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "default",
"connectUrl": "lost-Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"jvmId": "Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"template.type": "TARGET",
"pushType": "SCHEDULED"
}
},
"size": 622315,
"archivedTime": 1690487594
},
{
"name": "quarkus-test-agent_default_20230727T195344Z.jfr",
"downloadUrl": "/api/v3/download/V2I1UmFGaG1GY0IxTHlLdG41dzk0MEV0Q09BbDgydzJLQS0yUTZwUzVZZz0vcXVhcmt1cy10ZXN0LWFnZW50X2RlZmF1bHRfMjAyMzA3MjdUMTk1MzQ0Wi5qZnI",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "default",
"connectUrl": "lost-Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"jvmId": "Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"template.type": "TARGET",
"pushType": "SCHEDULED"
}
},
"size": 629972,
"archivedTime": 1690487624
},
{
"name": "quarkus-test-agent_default_20230727T195414Z.jfr",
"downloadUrl": "/api/v3/download/V2I1UmFGaG1GY0IxTHlLdG41dzk0MEV0Q09BbDgydzJLQS0yUTZwUzVZZz0vcXVhcmt1cy10ZXN0LWFnZW50X2RlZmF1bHRfMjAyMzA3MjdUMTk1NDE0Wi5qZnI",
"reportUrl": "TODO",
"metadata": {
"labels": {
"template.name": "default",
"connectUrl": "lost-Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"jvmId": "Wb5RaFhmFcB1LyKtn5w940EtCOAl82w2KA-2Q6pS5Yg=",
"template.type": "TARGET",
"pushType": "SCHEDULED"
}
},
"size": 313500,
"archivedTime": 1690487654
}
]
}
]This response contains archives pushed by an agent instance which are being properly pruned, but the list of archives coming from the rule definition is just growing over time. |
|
Okay, I think the problem is the naming scheme of the targets and the regex pattern that determines the recording name from the recording file name. private static final Pattern RECORDING_FILENAME_PATTERN = Pattern.compile( "([A-Za-z\\d\\.-]*)_([A-Za-z\\d-_]*)_([\\d]*T[\\d]*Z)(\\.[\\d]+)?(\\.jfr)?");The |
|
Right, makes sense. In the short term, sanitizing the input and applying transformations like that is fine - Cryostat has been doing that since as long as it has had archives. In the longer term I'm tempted to say let's do something much more radical. We can safely embed those details about the source target (alias, connectUrl, JVM ID, labels/annotations) into a
If we redo the tables for targets and active recordings so that we don't delete records when targets go offline or recordings are deleted, and instead add a status flag column, then we can always go back and look up the details of the source recording for an archived recording, and from there also look up the details of the source target. |
Does this affect the 2.3/2.4 codebase as well then? |
Never noticed, but seems like this was already done by Janelle 2 years ago now: String targetName =
platformClient.listDiscoverableServices().stream()
.filter(
serviceRef -> {
return serviceRef.getServiceUri().equals(serviceUri)
&& serviceRef.getAlias().isPresent();
})
.map(s -> s.getAlias().get())
.findFirst()
.orElse(connection.getHost())
.replaceAll("[\\._]+", "-");So I assume it's safe to continue with this, It probably makes sense to change it to include periods and the backslash too. |
Related #15
sample test queries: