Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(recordings): implement JFR snapshot #178

Merged
merged 14 commits into from
Nov 22, 2023
Merged

feat(recordings): implement JFR snapshot #178

merged 14 commits into from
Nov 22, 2023

Conversation

andrewazores
Copy link
Member

@andrewazores andrewazores commented Nov 21, 2023 •
edited
Loading

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main

Fixes: #177
See #42

Description of the change:

Reimplements JFR snapshot API v1 and v2, plus adds v3. These are all quite similar, just the response body format and status codes vary slightly.

How to manually test:

  1. ./mvnw clean verify ; podman image prune -f
  2. ./smoketest.bash -OXtb and wait for things to come up
  3. Select a target
  4. Recordings > Create > Snapshot > Create . This should fail and display a warning notification message about there being no source data to snapshot.
  5. Recordings > Create > Custom > create a new recording
  6. Repeat step 4, this time it should succeed.

@andrewazores andrewazores added feat New feature or request safe-to-test labels Nov 21, 2023
@andrewazores andrewazores changed the title feat(recordings): implement JFR snapshojt feat(recordings): implement JFR snapshot Nov 21, 2023
@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 11/22/2023, 10:47:16 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6959643557

@andrewazores andrewazores marked this pull request as ready for review November 22, 2023 15:51
@github-actions GitHub Actions
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6959643557

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 11/22/2023, 11:06:36 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6959867721

@andrewazores andrewazores requested a review from a team as a code owner November 22, 2023 16:14
@github-actions GitHub Actions
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6959867721

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 11/22/2023, 11:15:49 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6959975885

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6959975885

@andrewazores
Copy link
Member Author

/build_test

@github-actions GitHub Actions
Copy link

Workflow started at 11/22/2023, 11:26:58 AM. View Actions Run.

@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6960102046

1 similar comment
@github-actions GitHub Actions
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6960102046

aali309
aali309 approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@aali309 aali309 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good to me. Everything works as expected.

@andrewazores andrewazores merged commit 82f8802 into cryostatio:main Nov 22, 2023
8 checks passed
@andrewazores andrewazores deleted the recording-snapshot branch November 22, 2023 17:49
This was referenced Nov 22, 2023
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aali309 aali309 aali309 approved these changes

@mwangggg mwangggg Awaiting requested review from mwangggg

Assignees
No one assigned
Labels
feat New feature or request safe-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Reimplement JFR snapshot
2 participants
@andrewazores @aali309