Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(itest): updated the tests and created a localstack resource #160

Merged
merged 16 commits into from
Nov 21, 2023

Conversation

lkonno
Copy link
Contributor

@lkonno lkonno commented Nov 14, 2023

Welcome to Cryostat3! 👋

Before contributing, make sure you have:

  • Read the contributing guidelines
  • Linked a relevant issue which this PR resolves
  • Linked any other relevant issues, PR's, or documentation, if any
  • Resolved all conflicts, if any
  • Rebased your branch PR on top of the latest upstream main branch
  • Attached at least one of the following labels to the PR: [chore, ci, docs, feat, fix, test]
  • Signed all commits using a GPG signature

To recreate commits with GPG signature git fetch upstream && git rebase --force --gpg-sign upstream/main


Related to: #42

Description of the change:

Updated NonExistentTargetIT, NoopAuthV2IT, NotificationsUrlIT, changed RecordingWorkflowIT to RecordingWorkflowTest

Note: The RecordingWorkflowTest will fail because the report is returning in json format, but it is expecting html.

Motivation for the change:

Enable the tests

How to manually test:

mvn package

@lkonno lkonno requested a review from a team as a code owner November 14, 2023 16:01
@github-actions github-actions bot added the needs-triage Needs thorough attention from code reviewers label Nov 14, 2023
@lkonno lkonno changed the title updated the tests and created a localstack resource test(itest): updated the tests and created a localstack resource Nov 14, 2023
@andrewazores
Copy link
Member

Note: The RecordingWorkflowTest will fail because the report is returning in json format, but it is expecting html.

Ah yes. That is one API breaking change I am intentionally making for 3.0. In the old 1.0 -> 2.3 versions it was originally HTML only, then later HTML or JSON as per client request. In 2.4 and 3.0 it is only JSON.

@andrewazores andrewazores added test chore Refactor, rename, cleanup, etc. safe-to-test and removed needs-triage Needs thorough attention from code reviewers labels Nov 14, 2023
@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 11/14/2023, 3:32:45 PM. View Actions Run.

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6869167232

1 similar comment
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6869167232

@andrewazores
Copy link
Member

Looks like CI is just generally broken at the moment (on main too) because of some repository infra issue preventing the test runner from installing the newer version of podman that it needs.

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 11/15/2023, 10:35:51 AM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6879472627

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6879472627

2 similar comments
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6879472627

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6879472627

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 11/16/2023, 3:37:06 PM. View Actions Run.

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6896218440

1 similar comment
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6896218440

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 11/16/2023, 3:42:39 PM. View Actions Run.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6896266457

@andrewazores
Copy link
Member

/build_test

Copy link

Workflow started at 11/20/2023, 9:29:14 AM. View Actions Run.

Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6931502933

1 similar comment
Copy link

CI build and push: At least one test failed ❌
https://github.com/cryostatio/cryostat3/actions/runs/6931502933

@andrewazores
Copy link
Member

Bah, more CI outages.

Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6931495111

1 similar comment
Copy link

CI build and push: All tests pass ✅
https://github.com/cryostatio/cryostat3/actions/runs/6931495111

@andrewazores andrewazores force-pushed the itests-update branch 2 times, most recently from 4b95b49 to 341d246 Compare November 20, 2023 16:50
@andrewazores
Copy link
Member

Any other review feedback?

@lkonno
Copy link
Contributor Author

lkonno commented Nov 21, 2023

Looks good.

@andrewazores andrewazores merged commit 829584d into cryostatio:main Nov 21, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants