-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(itest): updated the tests and created a localstack resource #160
Conversation
Ah yes. That is one API breaking change I am intentionally making for 3.0. In the old 1.0 -> 2.3 versions it was originally HTML only, then later HTML or JSON as per client request. In 2.4 and 3.0 it is only JSON. |
4e139b8
to
c20ff1f
Compare
/build_test |
Workflow started at 11/14/2023, 3:32:45 PM. View Actions Run. |
CI build and push: At least one test failed ❌ |
1 similar comment
CI build and push: At least one test failed ❌ |
Looks like CI is just generally broken at the moment (on |
/build_test |
Workflow started at 11/15/2023, 10:35:51 AM. View Actions Run. |
CI build and push: All tests pass ✅ |
CI build and push: At least one test failed ❌ |
2 similar comments
CI build and push: At least one test failed ❌ |
CI build and push: At least one test failed ❌ |
b102ddd
to
61c2623
Compare
/build_test |
Workflow started at 11/16/2023, 3:37:06 PM. View Actions Run. |
CI build and push: At least one test failed ❌ |
1 similar comment
CI build and push: At least one test failed ❌ |
/build_test |
Workflow started at 11/16/2023, 3:42:39 PM. View Actions Run. |
CI build and push: All tests pass ✅ |
/build_test |
Workflow started at 11/20/2023, 9:29:14 AM. View Actions Run. |
CI build and push: At least one test failed ❌ |
1 similar comment
CI build and push: At least one test failed ❌ |
Bah, more CI outages. |
CI build and push: All tests pass ✅ |
1 similar comment
CI build and push: All tests pass ✅ |
4b95b49
to
341d246
Compare
Any other review feedback? |
Looks good. |
… s3 buckets as subdomains
341d246
to
c173fdb
Compare
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
main
branch[chore, ci, docs, feat, fix, test]
To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/main
Related to: #42
Description of the change:
Updated NonExistentTargetIT, NoopAuthV2IT, NotificationsUrlIT, changed RecordingWorkflowIT to RecordingWorkflowTest
Note: The RecordingWorkflowTest will fail because the report is returning in json format, but it is expecting html.
Motivation for the change:
Enable the tests
How to manually test:
mvn package