chore(templates): ensure named templates follow helm best practices #160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
approved these changes
Jun 27, 2024
|
Seems worthwhile. |
mergify bot
pushed a commit
that referenced
this pull request
Jun 27, 2024
…160) * chore(proxy): prefix partial templates with underscore * chore(templates): prefex named template with chart name * chore(deploy): remove duplicate securityContext field and blank space * chore(templates): add comments for named templates * fix(notes): fix nil pointer exceptions * fix: non-empty tls should show https url (cherry picked from commit 8115c82)
andrewazores
pushed a commit
that referenced
this pull request
Jun 27, 2024
…160) (#163) * chore(proxy): prefix partial templates with underscore * chore(templates): prefex named template with chart name * chore(deploy): remove duplicate securityContext field and blank space * chore(templates): add comments for named templates * fix(notes): fix nil pointer exceptions * fix: non-empty tls should show https url (cherry picked from commit 8115c82) Co-authored-by: Thuan Vo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #110
Related to #159 (some are required for helm unittest to function, i.e. point [1] and [2])
What's changed
Changes that follow best practices:
.tplto have underscore prefix_. [1]Changes that might impact chart installation:
securityContextfield for storage container. [2]NOTEs.txtwith ingress enabled.References