-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Test): template tests #159
Conversation
Working on |
@aali309 We should also create a workflow to run these tests on PR and push. What do you think? |
Will do that as well |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good start! I think there are still cases and validations that need covering.
As for the NOTES.txt
, you can do the following, for example:
suite: Test NOTES.txt
templates:
- templates/NOTES.txt
tests:
- it: should be render correct notes for enabled ingress
set:
core.ingress.enabled: true
core:
ingress:
className: nginx
hosts:
- host: example.com
paths:
- path: /
pathType: Prefix
tls:
- hosts:
- example.com
secretName: example-tls
asserts:
- equalRaw:
value: |
1. Visit the Cryostat application at:
```
https://example.com/
```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fantastic work @aali309!
I will be adding more test cases on this. |
ping @andrewazores @ebaron |
Looks great! Just the two tiny notes above. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! This is awesome!
see #142