Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): added unittest workflow #164

Closed
wants to merge 2 commits into from

Conversation

aali309
Copy link
Contributor

@aali309 aali309 commented Jul 3, 2024

suggested as part of: #159

@aali309 aali309 added feat New feature or request safe-to-test labels Jul 3, 2024
@aali309 aali309 self-assigned this Jul 3, 2024
@aali309
Copy link
Contributor Author

aali309 commented Jul 3, 2024

link: https://github.com/aali309/cryostat-helm/actions/runs/9781866183/job/27006928374

Sample local run:
image

- name: Set up Helm
uses: azure/setup-helm@v4
with:
version: v3.15.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using v3.14.4 in other CI. Let's keep it at 3.14 for now and bump later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or may be change v3.14.4 to match the latest?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure that would work! Though, it's better to bump the version in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If something goes wrong with fetching the latest version the action will use the hardcoded default stable version (currently v3.13.3). If you rely on a certain version higher than the default, you should explicitly use that version instead of latest.

We need to be careful there since helm 3.13 might be used, while the min helm version required is 3.14.

Copy link
Member

@tthvo tthvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I would suggest having these changes included in #159 instead so that we can see the tests run in that PR too.

- uses: actions/checkout@v4
with:
fetch-depth: 0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this blank line can be removed

@aali309 aali309 closed this Jul 3, 2024
@aali309 aali309 deleted the unittestOnPush branch July 3, 2024 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat New feature or request safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants