-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cleanup): Abstract away document type #389
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
7 tasks
To run smoketest:
|
To run smoketest:
|
src/main/java/io/cryostat/core/templates/RemoteTemplateService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/cryostatio/cryostat-core/actions/runs/9100166142/job/25014375192?pr=389
[INFO] -------------------------------------------------------------
Error: COMPILATION ERROR :
[INFO] -------------------------------------------------------------
Error: /home/runner/work/cryostat-core/cryostat-core/src/main/java/io/cryostat/core/templates/RemoteTemplateService.java:[87,42] cannot find symbol
symbol: variable document
location: class io.cryostat.core.templates.RemoteTemplateService
Error: /home/runner/work/cryostat-core/cryostat-core/src/main/java/io/cryostat/core/templates/RemoteTemplateService.java:[88,39] incompatible types: java.util.Optional<java.lang.Object> cannot be converted to java.util.Optional<java.lang.String>
[INFO] 2 errors
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 5.671 s
[INFO] Finished at: 2024-05-15T17:31:46Z
[INFO] ------------------------------------------------------------------------
To run smoketest:
|
….java Co-authored-by: Andrew Azores <[email protected]> Signed-off-by: Joshua Matsuoka <[email protected]>
andrewazores
force-pushed
the
document-cleanup
branch
from
May 21, 2024 17:16
e06d82c
to
1179619
Compare
andrewazores
approved these changes
May 21, 2024
To run smoketest:
|
andrewazores
approved these changes
May 21, 2024
This was referenced Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up the template service to avoid exposing the document type, changing getXML to return the XML string directly as it's used in the S3 template service/api handlers.
Fixes #300