Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cleanup): Abstract away document type #389

Merged
merged 3 commits into from
May 21, 2024

Conversation

Josh-Matsuoka
Copy link
Contributor

This PR cleans up the template service to avoid exposing the document type, changing getXML to return the XML string directly as it's used in the S3 template service/api handlers.

Fixes #300

Copy link

github-actions bot commented May 9, 2024

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-389-c5928b365ef5d49a7e42fc5eb60b402a31a1398f-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-389-c5928b365ef5d49a7e42fc5eb60b402a31a1398f-linux-java17 bash smoketest.bash

Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-389-c5928b365ef5d49a7e42fc5eb60b402a31a1398f-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-389-c5928b365ef5d49a7e42fc5eb60b402a31a1398f-linux-java17 bash smoketest.bash

Copy link
Member

@andrewazores andrewazores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/cryostatio/cryostat-core/actions/runs/9100166142/job/25014375192?pr=389

 [INFO] -------------------------------------------------------------
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/cryostat-core/cryostat-core/src/main/java/io/cryostat/core/templates/RemoteTemplateService.java:[87,42] cannot find symbol
  symbol:   variable document
  location: class io.cryostat.core.templates.RemoteTemplateService
Error:  /home/runner/work/cryostat-core/cryostat-core/src/main/java/io/cryostat/core/templates/RemoteTemplateService.java:[88,39] incompatible types: java.util.Optional<java.lang.Object> cannot be converted to java.util.Optional<java.lang.String>
[INFO] 2 errors 
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  5.671 s
[INFO] Finished at: 2024-05-15T17:31:46Z
[INFO] ------------------------------------------------------------------------

Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-389-e06d82c1c45003a4183b3027a5903358fc488d80-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-389-e06d82c1c45003a4183b3027a5903358fc488d80-linux-java17 bash smoketest.bash

Copy link

ARCH IMAGE
amd64 ghcr.io/cryostatio/cryostat-core:pr-389-1179619003c1ba282534f95b33b8508080303a3a-linux-java17

To run smoketest:

CRYOSTAT_IMAGE=ghcr.io/cryostatio/cryostat-core:pr-389-1179619003c1ba282534f95b33b8508080303a3a-linux-java17 bash smoketest.bash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Refactor, rename, cleanup, etc. safe-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Task] Replace JSoup with Jackson
2 participants