chore(cleanup): Adjust for core changes to abstract away the Document type #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewazores
force-pushed
the
document-cleanup
branch
from
2e70675 to
0f5921e
Compare
|
/build_test |
|
Workflow started at 5/21/2024, 1:52:40 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
7 tasks
andrewazores
approved these changes
May 21, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: cryostatio/cryostat-core#300
Related To: cryostatio/cryostat-core#389
Description of the change:
Adjusts the S3TemplateService and API handlers to account for proposed changes to the TemplateService to avoid directly exposing the Document type.
The S3TemplateService still knows about the Document type and uses it since that's its' implementation, however it does not expose it to callers of getXML.
Motivation for the change:
This change is helpful because users may want to...
How to manually test:
Tested with ./mvnw run:quarkus-dev and testing the event template functionality/starting recordings with templates.