fix(recordings): correctly retrieve custom event templates from S3 storage #492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR/issue depends on: |
andrewazores
force-pushed
the
gh491
branch
2 times, most recently
from
47b06c0 to
6c0db23
Compare
|
/build_test |
|
Workflow started at 6/3/2024, 4:27:01 PM. View Actions Run. |
|
CI build and push: At least one test failed ❌ (JDK17) |
|
Ah right, CI won't work until after cryostatio/cryostat-core#403 . |
|
/build_test |
|
Workflow started at 6/3/2024, 5:39:52 PM. View Actions Run. |
|
No OpenAPI schema changes detected. |
|
No GraphQL schema changes detected. |
|
CI build and push: All tests pass ✅ (JDK17) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Welcome to Cryostat3! 👋
Before contributing, make sure you have:
mainbranch[chore, ci, docs, feat, fix, test]To recreate commits with GPG signature
git fetch upstream && git rebase --force --gpg-sign upstream/mainFixes: #491
Depends on cryostatio/cryostat-core#403
See #342
See cryostatio/cryostat-core#389
Description of the change:
Some recent patches to Cryostat and cryostat-core changed how event templates are handled. The current Cryostat
mainhas a bug where custom event templates can be successfully uploaded to storage, listed, and downloaded back from storage, but when trying to use the template to create a new recording then the action fails. The root of the failure is that Cryostat tries to start the recording by asking the -core service implementation to start the recording using the custom event template, but that is no longer implemented in 3.0 - this is the code path that in <=2.4 would check for the custom event template on direct disk storage. The new implementation in this PR checks if the desired template is a custom one, and if so retrieves it from S3 storage first before passing it back through the same old code path to start the recording.How to manually test:
./mvnw clean installit. Then check out and build this PR:./mvnw -o clean package ; podman image prune -f../smoktest.bash -Ot<configuration>element