Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add caller workflow for publishing service artifacts #443

Merged
merged 2 commits into from
May 2, 2023

Conversation

turkenf
Copy link
Collaborator

@turkenf turkenf commented Apr 26, 2023

Description of your changes

Consumes reusable workflows introduced in upbound/official-providers-ci#94

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Manually tested on turkenf/uptest and turkenf/provider-azure

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can wait for the partitioning PRs (e.g., #442) before merging this.

@turkenf turkenf marked this pull request as ready for review May 2, 2023 11:24
@turkenf turkenf requested a review from sergenyalcin as a code owner May 2, 2023 11:24
@turkenf turkenf force-pushed the publish-service-artifacts branch from f3b0f67 to deda294 Compare May 2, 2023 12:22
@turkenf turkenf force-pushed the publish-service-artifacts branch from deda294 to 1c3be42 Compare May 2, 2023 12:41
Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenf, lgtm.

@turkenf turkenf merged commit d0174ea into crossplane-contrib:main May 2, 2023
@turkenf turkenf deleted the publish-service-artifacts branch May 2, 2023 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants