-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Break provider-azure up by service #442
Conversation
3c0d958
to
4262eb2
Compare
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Hasan Turken <[email protected]>
- Default the SUBPACKAGES make var to only "monolith" Signed-off-by: Hasan Turken <[email protected]>
/test-examples="examples/network/virtualnetwork.yaml" |
Signed-off-by: Hasan Turken <[email protected]>
Signed-off-by: Alper Rifat Ulucinar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @turkenh, lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an ETA on when the subpackages will be officially released? Are there prereleases we can help you testing with? |
@lippertmarkus we are aiming for official release on 13 June. There are release candidates available for testing: https://docs.google.com/document/d/1tmXi3CRhCKNvdDTApzfNsBIFF88qhpUQth3t5y5oKew/edit You can report issues/ask questions in community Slack: #sig-service-scoped-providers |
Description of your changes
Relevant proposal: crossplane/crossplane#3939
Depends on: crossplane/upjet#194
Following the changes in: crossplane-contrib/provider-upjet-aws#680
This PR proposes the following changes according to the proposal crossplane/crossplane#3939:
pkg.crossplane.io/provider-family
label in its package metadata.It also introduces the
SUBPACKAGES
make variable so that it's possible to build the individual subpackages. An example for building is:make -j 3 SUBPACKAGES="monolith config network" build.all
One can also use the same variable to push those (already built) packages:
make -j 3 SUBPACKAGES="monolith config network" BRANCH_NAME=main publish
I have:
make reviewable test
to ensure this PR is ready for review.How has this code been tested
Successfully built and pushed the monolith, config and network subpackages:
I was able to set up and delete a ResourceGroup and a VirtualNetwork.network that relies on it using the
turkenh/provider-azure-network:v0.31.0-rc.1.11.g1d0143f4
package.