Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Break provider-azure up by service #442

Merged
merged 7 commits into from
May 2, 2023

Conversation

turkenh
Copy link
Contributor

@turkenh turkenh commented Apr 26, 2023

Description of your changes

Relevant proposal: crossplane/crossplane#3939
Depends on: crossplane/upjet#194
Following the changes in: crossplane-contrib/provider-upjet-aws#680

This PR proposes the following changes according to the proposal crossplane/crossplane#3939:

  • Subpackages belonging to each API group is produced. An example is: provider-azure-network.
  • ProviderConfig, ProviderConfigUsage and StoreConfig are part of a config package named provider-azure-config.
  • The monolith package (containing all the CRDs and associated controllers) is still produced.
  • Each produced package except for the monolith package has the pkg.crossplane.io/provider-family label in its package metadata.
  • Each service package except for the config package declares a dependency to the config package.

It also introduces the SUBPACKAGES make variable so that it's possible to build the individual subpackages. An example for building is:

make -j 3 SUBPACKAGES="monolith config network" build.all

One can also use the same variable to push those (already built) packages:

make -j 3 SUBPACKAGES="monolith config network" BRANCH_NAME=main publish

I have:

  • Run make reviewable test to ensure this PR is ready for review.

How has this code been tested

Successfully built and pushed the monolith, config and network subpackages:

  • turkenh/provider-azure-config:v0.31.0-rc.1.11.g1d0143f4
  • turkenh/provider-azure-network:v0.31.0-rc.1.11.g1d0143f4
  • turkenh/provider-azure:v0.31.0-rc.1.11.g1d0143f4

I was able to set up and delete a ResourceGroup and a VirtualNetwork.network that relies on it using the turkenh/provider-azure-network:v0.31.0-rc.1.11.g1d0143f4 package.

Signed-off-by: Hasan Turken <[email protected]>
- Default the SUBPACKAGES make var to only "monolith"

Signed-off-by: Hasan Turken <[email protected]>
@turkenh
Copy link
Contributor Author

turkenh commented Apr 28, 2023

/test-examples="examples/network/virtualnetwork.yaml"

Copy link
Collaborator

@ulucinar ulucinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @turkenh, lgtm.

Copy link
Contributor

@ezgidemirel ezgidemirel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the change with platform-ref-azure. Thanks @turkenh and @ulucinar

@ulucinar ulucinar merged commit 7cf9f8d into crossplane-contrib:main May 2, 2023
@lippertmarkus
Copy link

lippertmarkus commented May 27, 2023

Do you have an ETA on when the subpackages will be officially released? Are there prereleases we can help you testing with?

@jeanduplessis
Copy link
Collaborator

@lippertmarkus we are aiming for official release on 13 June.

There are release candidates available for testing: https://docs.google.com/document/d/1tmXi3CRhCKNvdDTApzfNsBIFF88qhpUQth3t5y5oKew/edit

You can report issues/ask questions in community Slack: #sig-service-scoped-providers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants