Add reusable workflow for publishing service artifacts #94
Conversation
| if: ${{ github.actor == 'OWNER' || github.actor == 'turkenf' || contains(github.event.repository.collaborators, github.actor) }} | ||
| runs-on: ubuntu-22.04 | ||
|
|
||
| steps: |
There was a problem hiding this comment.
Not with this initial PR but as a next step, we should consider parallelizing using a matrix strategy.
jobs:
package_matrix:
strategy:
matrix:
subpackage: [config, ec2, rds] # consider calculating this from sub packages input.
arch: [amd64, arm64]
There was a problem hiding this comment.
I think we had better also give this a try @turkenf. The disadvantage might be the initial setup needed for running these jobs that are normally be shared by the build process (such as buildx setup, caching, vendoring, etc.) will be duplicated. But we may find a way to share this step between the jobs generated by the matrix strategy.
There was a problem hiding this comment.
I have the idea of triggering the publish-service-artifacts job via the gh tool.
turkenf
force-pushed
the
provider-publish-service-artifacts
branch
from
963b5e1
to
9b9d952
Compare
turkenf
force-pushed
the
provider-publish-service-artifacts
branch
from
9b9d952
to
4d6a5a1
Compare
turkenf
force-pushed
the
provider-publish-service-artifacts
branch
from
4d6a5a1
to
1f4de98
Compare
turkenf
force-pushed
the
provider-publish-service-artifacts
branch
from
1f4de98
to
c766dd1
Compare
| workflow_call: | ||
| inputs: | ||
| subpackages: | ||
| description: 'Subpackages to be built individually (e.g. monolith config ec2)' |
There was a problem hiding this comment.
The default value could be monolith.
|
|
||
| on: | ||
| workflow_call: | ||
| inputs: |
There was a problem hiding this comment.
Could you please also add the following input parameters to this workflow?
version: Required, no default (ideally we would like to makeversionoptional and only set theVERSIONmake variable if theversionGithub workflow input parameter is specified but we can do this in a follow-up PR). Again we need to set theVERSIONmake variable in bothPublish Artifacts&Build Artifactssteps. An example value for the description could be:v0.1.0.
|
|
||
| - name: Publish Artifacts | ||
| run: | | ||
| make -j ${{ steps.build_artifacts.outputs.num_packages }} SUBPACKAGES="${{ inputs.subpackages }}" publish |
There was a problem hiding this comment.
Could you please hardcode the following so that we only build & push for the release candidates organization?
We had better hardcode the following make variables in Publish Artifacts & Build Artifacts steps: make -j $num_packages SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE=upbound-release-candidates build.all.
|
|
||
| - name: Publish Artifacts | ||
| run: | | ||
| make -j ${{ steps.build_artifacts.outputs.num_packages }} SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE =xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} publish |
There was a problem hiding this comment.
| make -j ${{ steps.build_artifacts.outputs.num_packages }} SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE =xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} publish | |
| make -j ${{ steps.build_artifacts.outputs.num_packages }} SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE=xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} publish |
| if [ $num_packages -gt 10 ]; then | ||
| num_packages=10 | ||
| fi | ||
| make -j $num_packages SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE =xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} build.all |
There was a problem hiding this comment.
| make -j $num_packages SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE =xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} build.all | |
| make -j $num_packages SUBPACKAGES="${{ inputs.subpackages }}" XPKG_REG_ORGS=xpkg.upbound.io/upbound-release-candidates XPKG_REG_ORGS_NO_PROMOTE=xpkg.upbound.io/upbound-release-candidates VERSION=${{ inputs.version }} build.all |
turkenf
force-pushed
the
provider-publish-service-artifacts
branch
from
35cde7d
to
3948f2f
Compare
Description of your changes
This PR adds a reusable workflow to be reused by official provider repositories for publishing service artifacts.
I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
Manually tested on
turkenf/uptestandturkenf/provider-azure