Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

False positive "PN" should be "ON" in "PNGs" #967

Closed
emilk opened this issue Apr 2, 2024 · 1 comment
Closed

False positive "PN" should be "ON" in "PNGs" #967

emilk opened this issue Apr 2, 2024 · 1 comment

Comments

@emilk
Copy link

emilk commented Apr 2, 2024

For some reason typos triggeres on the word PNGs:

error: `PN` should be `ON`
  --> ./rerun_cpp/docs/Doxyfile:1552:71
     |
1552 | # https://inkscape.org) to generate formulas as SVG images instead of PNGs for
     |                                                                       ^^
arnaucube added a commit to privacy-scaling-explorations/sonobe that referenced this issue Apr 2, 2024
@arnaucube
Fix typos version to v1.19.0
0c8c45c 
The reason is that the last release (v1.20.0) includes new aggresive
typos that give false positives. The community is already alerting about
it, eg:
crate-ci/typos#963
crate-ci/typos#967
crate-ci/typos#970
and in our case we were geting 'RO' (random oracle) corrected to 'to',
and 'ws' (array of witnessess) to 'was'.
Keeping with version v1.19.0 while typos gets updated and a new version
is release fixing the false positives.
arnaucube added a commit to privacy-scaling-explorations/sonobe that referenced this issue Apr 2, 2024
@arnaucube
Fix typos version to v1.19.0
ad43c3f 
The reason is that the last release (v1.20.0) includes new aggresive
typos that give false positives. The community is already alerting about
it, eg:
crate-ci/typos#963
crate-ci/typos#967
crate-ci/typos#970
and in our case we were geting 'RO' (random oracle) corrected to 'to',
and 'ws' (array of witnessess) to 'was'.
Keeping with version v1.19.0 while typos gets updated and a new version
is release fixing the false positives.
@SorenSpicknall SorenSpicknall mentioned this issue Apr 2, 2024
Merged
6 tasks
@epage
Copy link
Collaborator

epage commented Apr 2, 2024

Closing in favor of #745

@epage epage closed this as not planned Won't fix, can't repro, duplicate, stale Apr 2, 2024
@arnaucube arnaucube mentioned this issue Apr 3, 2024
Merged
@epage epage mentioned this issue Apr 9, 2024
Closed
@benegee benegee mentioned this issue Apr 12, 2024
Closed
@epage epage mentioned this issue Apr 16, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@epage @emilk