Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various false positives since 1.20 #970

Closed
groengpx opened this issue Apr 2, 2024 · 4 comments · Fixed by tensorchord/pgvecto.rs#453 or #975
Closed

Various false positives since 1.20 #970

groengpx opened this issue Apr 2, 2024 · 4 comments · Fixed by tensorchord/pgvecto.rs#453 or #975

Comments

@groengpx
Copy link

groengpx commented Apr 2, 2024

  • IIS is corrected to IS (IIS is the webserver from Microsoft)
  • iot is corrected to it (iot is short for internet of things)

Also, I found a few aggressive corrections. These corrections are probably fine, but I will list them nonetheless:

  • ang is corrected to and (I used it as short for angle, but I probably should not short it.)
  • dur is corrected to due (I used it as short for duration).
@cutecutecat cutecutecat mentioned this issue Apr 2, 2024
Merged
arnaucube added a commit to privacy-scaling-explorations/sonobe that referenced this issue Apr 2, 2024
@arnaucube
Fix typos version to v1.19.0
0c8c45c 
The reason is that the last release (v1.20.0) includes new aggresive
typos that give false positives. The community is already alerting about
it, eg:
crate-ci/typos#963
crate-ci/typos#967
crate-ci/typos#970
and in our case we were geting 'RO' (random oracle) corrected to 'to',
and 'ws' (array of witnessess) to 'was'.
Keeping with version v1.19.0 while typos gets updated and a new version
is release fixing the false positives.
arnaucube added a commit to privacy-scaling-explorations/sonobe that referenced this issue Apr 2, 2024
@arnaucube
Fix typos version to v1.19.0
ad43c3f 
The reason is that the last release (v1.20.0) includes new aggresive
typos that give false positives. The community is already alerting about
it, eg:
crate-ci/typos#963
crate-ci/typos#967
crate-ci/typos#970
and in our case we were geting 'RO' (random oracle) corrected to 'to',
and 'ws' (array of witnessess) to 'was'.
Keeping with version v1.19.0 while typos gets updated and a new version
is release fixing the false positives.
@JakobLichterfeld JakobLichterfeld mentioned this issue Apr 2, 2024
Closed
@svix-jplatte
Copy link

Another one: ro (common abbreviation for read-only) is now marked as a typo.

@tlambert03 tlambert03 mentioned this issue Apr 2, 2024
Merged
@epage
Copy link
Collaborator

epage commented Apr 2, 2024

Looking around, ang and dur seem like common enough abbreviations to include

@epage epage mentioned this issue Apr 2, 2024
Merged
@RudolfMan
Copy link

After upgrade to 1.20.0 Our pipeline started also failing on

  • hd - in JWT it's a claim name for "host domain"
  • ws - from Postgres CONCAT_WS to concatenate strings with a separator
  • ein - Employer Identification Number

@epage epage closed this as completed in #975 Apr 2, 2024
@epage epage closed this as completed in 14516cb Apr 2, 2024
@epage
Copy link
Collaborator

epage commented Apr 2, 2024

Its better to post to new issues rather than

  • Posting to closed issues
  • Posting to issues on separate topics

btw ws was tracked in #963

@arnaucube arnaucube mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@epage @RudolfMan @groengpx @svix-jplatte