Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily pin crate-ci/typos to avoid broken alerting on "png" #3322

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

SorenSpicknall
Copy link
Contributor

@SorenSpicknall SorenSpicknall commented Apr 2, 2024

Description

We use a source code spell checker to audit our /docs folder during each run of our linting CI task. Its most recent release, v1.20, introduced a false positive on variations of the "png" file extension, causing failed CI runs like this one. An Issue is open on the typos repository here, but in the meantime we should revert to the previous version until a fix is out.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Will test live in CI, since this impacts the linting GitHub Action

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Unpin once the open issue about this problem on the typos repository is resolved in a new release.

Copy link
Contributor

@vevetron vevetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vevetron vevetron merged commit c0cb5cf into main Apr 2, 2024
1 check passed
@vevetron vevetron deleted the temp-pin_typos branch April 2, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants