feat: Use new downloadFile() method from cozy-client
#2690
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 26, 2024
JF-Cozy
approved these changes
Aug 27, 2024
react/Viewer/helpers.js
Outdated
| return client.collection('io.cozy.files').forceFileDownload(url, file.name) | ||
| } | ||
| return client.collection('io.cozy.files').download(file) | ||
| export const downloadFile = async ({ client, file, url, webviewIntent }) => { |
There was a problem hiding this comment.
on pourrait plutôt faire un BC (avec éventuellement codemods) je pense, un réexport de fonction d'une lib à l'autre ça me semble délicat...
There was a problem hiding this comment.
J'ai fais le changement avec un BC, mais je n'ai pas fait de codemods, je n'ai pas vu de trace de cet appel hors cozy-ui donc je ne pense pas que ça existe
5 tasks
Ldoppea
force-pushed
the
feat/download_files_offline
branch
from
032724a
to
e9e37f2
Compare
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `react/Vierwer/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
force-pushed
the
feat/download_files_offline
branch
from
e9e37f2
to
a64adb0
Compare
|
Closed in favor of cozy/cozy-libs#2581 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cozy/cozy-client#1518 we implemented a new
downloadFile()that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship appThis commit will replace the old way to download files with the new one using
downloadFile()Related PRs:
downloadFilemethod infilemodel cozy-client#1518