Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add downloadFile method in file model #1518

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Aug 26, 2024

For the Flagship app offline feature, we want to make some files available offline

To make this possible, we want the cozy-apps to download files as usual except when they are hosted in the FlagshipApp

In that scenario, we want the cozy-app to call the new downloadFile intent

Also to ease future compatibility, we want to implement a new method hosted in the file model instead of in the collection as before

So in order to handle offline files, the cozy-app will now need to call downloadFile() method from models/file


Related PRs:

Ldoppea added a commit to cozy/cozy-ui that referenced this pull request Aug 26, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Aug 26, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit to cozy/cozy-ui that referenced this pull request Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`react/Vierwer/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Ldoppea added a commit to cozy/cozy-ui that referenced this pull request Aug 27, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`react/Vierwer/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Base automatically changed from docs/fix_links_constructor to feat/meta_offline September 9, 2024 13:40
For the Flagship app offline feature, we want to make some files
available offline

To make this possible, we want the cozy-apps to download files as usual
except when they are hosted in the FlagshipApp

In that scenario, we want the cozy-app to call the new `downloadFile`
intent

Also to ease future compatibility, we want to implement a new method
hosted in the `file` model instead of in the collection as before

So in order to handle offline files, the cozy-app will now need to call
`downloadFile()` method from `models/file`
@Ldoppea Ldoppea merged commit f6552cd into feat/meta_offline Sep 9, 2024
2 checks passed
@Ldoppea Ldoppea deleted the feat/download_files_flagship branch September 9, 2024 13:50
Ldoppea added a commit that referenced this pull request Sep 11, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit that referenced this pull request Sep 12, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit that referenced this pull request Sep 12, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit to cozy/cozy-libs that referenced this pull request Sep 12, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`cozy-viewer/src/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit to cozy/cozy-libs that referenced this pull request Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`cozy-viewer/src/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Ldoppea added a commit that referenced this pull request Sep 13, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Sep 13, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit that referenced this pull request Sep 19, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit that referenced this pull request Sep 19, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit that referenced this pull request Sep 24, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit that referenced this pull request Sep 24, 2024
Previous implementation would not be backward compatible with older
Flagship app versions

By checking for method availability, we ensure the code is called only
on the correct Flagship app versions, otherwise the old process is
called

Related PR: #1518
Ldoppea added a commit to cozy/cozy-libs that referenced this pull request Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`cozy-viewer/src/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Ldoppea added a commit to cozy/cozy-libs that referenced this pull request Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`cozy-viewer/src/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Sep 24, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Sep 25, 2024
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant