feat(cozy-viewer): Use new downloadFile() method from cozy-client
#2581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ldoppea
force-pushed
the
feat/download_files_offline
branch
from
67ccabc
to
98f3f0b
Compare
5 tasks
paultranvan
approved these changes
Sep 13, 2024
This was referenced Sep 13, 2024
This version introduces the new `downloadFile()` method that is compatible with Offline mode Related PR: cozy/cozy-client#1507 BREAKING CHANGE: cozy-viewer now requires cozy-client >= 49.0.0 (used for offline support)
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app This commit will replace the old way to download files with the new one using `downloadFile()` BREAKING CHANGE: `downloadFile()` method has been removed from `cozy-viewer/src/helpers.js`. Use the one from `cozy-client/dist/models/file` instead
Ldoppea
force-pushed
the
feat/download_files_offline
branch
from
98f3f0b
to
e61cd48
Compare
Ldoppea
added a commit
to cozy/mespapiers
that referenced
this pull request
Sep 24, 2024
`cozy-viewer` has been upgraded to `2.0.0` in order to retrieve changes on how files are downloaded in order to handle Offline mode Related PR: cozy/cozy-libs#2581
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cozy/cozy-client#1518 we implemented a new
downloadFile()that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship appThis commit will replace the old way to download files with the new one using
downloadFile()BREAKING CHANGE:
downloadFile()method has been removed fromcozy-viewer/src/helpers.js. Use the one fromcozy-client/dist/models/fileinsteadBREAKING CHANGE: cozy-viewer now requires cozy-client >= 49.0.0 (used for offline support)
Related PRs:
downloadFilemethod infilemodel cozy-client#1518TODO: