Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cozy-viewer): Use new downloadFile() method from cozy-client #2581

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

Ldoppea
Copy link
Member

@Ldoppea Ldoppea commented Sep 12, 2024

In cozy/cozy-client#1518 we implemented a new downloadFile() that allow to download files as before in a browser, but will download files through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one using downloadFile()

BREAKING CHANGE: downloadFile() method has been removed from cozy-viewer/src/helpers.js. Use the one from
cozy-client/dist/models/file instead

BREAKING CHANGE: cozy-viewer now requires cozy-client >= 49.0.0 (used for offline support)


Related PRs:


TODO:

This version introduces the new `downloadFile()` method that is
compatible with Offline mode

Related PR: cozy/cozy-client#1507

BREAKING CHANGE: cozy-viewer now requires cozy-client >= 49.0.0 (used
for offline support)
In cozy/cozy-client#1518 we implemented a new `downloadFile()` that
allow to download files as before in a browser, but will download files
through cozy-intent when hosted in the Flagship app

This commit will replace the old way to download files with the new one
using `downloadFile()`

BREAKING CHANGE: `downloadFile()` method has been removed from
`cozy-viewer/src/helpers.js`. Use the one from
`cozy-client/dist/models/file` instead
@Ldoppea Ldoppea merged commit d654334 into master Sep 24, 2024
3 checks passed
@Ldoppea Ldoppea deleted the feat/download_files_offline branch September 24, 2024 14:02
Ldoppea added a commit to cozy/mespapiers that referenced this pull request Sep 24, 2024
`cozy-viewer` has been upgraded to `2.0.0` in order to retrieve changes
on how files are downloaded in order to handle Offline mode

Related PR: cozy/cozy-libs#2581
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants