Sync feature with main branch #6346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.62.1 to 1.63.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/grpc/grpc-go/releases">google.golang.org/grpc's releases</a>.</em></p> <blockquote> <h2>Release 1.63.0</h2> <h1>Behavior Changes</h1> <ul> <li>grpc: Return canonical target string from <code>resolver.Address.String()</code> (experimental) (<a href="https://redirect.github.com/grpc/grpc-go/issues/6923">#6923</a>)</li> <li>client & server: when using write buffer pooling, use input value for buffer size instead of size*2 (<a href="https://redirect.github.com/grpc/grpc-go/issues/6983">#6983</a>) <ul> <li>Special Thanks: <a href="https://github.com/raghav-stripe"><code>@raghav-stripe</code></a></li> </ul> </li> </ul> <h1>New Features</h1> <ul> <li>grpc: add <code>ClientConn.CanonicalTarget()</code> to return the canonical target string. (<a href="https://redirect.github.com/grpc/grpc-go/issues/7006">#7006</a>)</li> <li>xds: implement LRS named metrics support (<a href="https://github.com/grpc/proposal/blob/master/A64-lrs-custom-metrics.md">gRFC A64</a>) (<a href="https://redirect.github.com/grpc/grpc-go/issues/7027">#7027</a>) <ul> <li>Special Thanks: <a href="https://github.com/danielzhaotongliu"><code>@danielzhaotongliu</code></a></li> </ul> </li> <li>grpc: introduce <code>grpc.NewClient</code> to allow users to create new clients in idle mode and with "dns" as the default resolver (<a href="https://redirect.github.com/grpc/grpc-go/issues/7010">#7010</a>) <ul> <li>Special Thanks: <a href="https://github.com/bruuuuuuuce"><code>@bruuuuuuuce</code></a></li> </ul> </li> </ul> <h1>API Changes</h1> <ul> <li>grpc: stabilize experimental method <code>ClientConn.Target()</code> (<a href="https://redirect.github.com/grpc/grpc-go/issues/7006">#7006</a>)</li> </ul> <h1>Bug Fixes</h1> <ul> <li>xds: fix an issue that would cause the client to send an empty list of resources for LDS/CDS upon reconnecting with the management server (<a href="https://redirect.github.com/grpc/grpc-go/issues/7026">#7026</a>)</li> <li>server: Fix some errors returned by a server when using a <code>grpc.Server</code> as an <code>http.Handler</code> with the Go stdlib HTTP server (<a href="https://redirect.github.com/grpc/grpc-go/issues/6989">#6989</a>)</li> <li>resolver/dns: add <code>SetResolvingTimeout</code> to allow configuring the DNS resolver's global timeout (<a href="https://redirect.github.com/grpc/grpc-go/issues/6917">#6917</a>) <ul> <li>Special Thanks: <a href="https://github.com/and1truong"><code>@and1truong</code></a></li> </ul> </li> <li>Set the security level of Windows named pipes to NoSecurity (<a href="https://redirect.github.com/grpc/grpc-go/issues/6956">#6956</a>) <ul> <li>Special Thanks: <a href="https://github.com/irsl"><code>@irsl</code></a></li> </ul> </li> </ul> <h2>Release 1.62.2</h2> <h1>Dependencies</h1> <ul> <li>Update http2 library to address vulnerability <a href="https://www.kb.cert.org/vuls/id/421644">CVE-2023-45288</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/grpc/grpc-go/commit/c68f4566b9cacdb11c42a6eb14ee66a33d9b7c12"><code>c68f456</code></a> Change version to 1.63.0 (<a href="https://redirect.github.com/grpc/grpc-go/issues/7050">#7050</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/6369167ae33538aca051225fe5b5e07c2b022eb5"><code>6369167</code></a> *: update http2 dependency (<a href="https://redirect.github.com/grpc/grpc-go/issues/7082">#7082</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/88547614e7427f7ce87a5f5485d897ae09044641"><code>8854761</code></a> cherry-pick: channelz: fix race accessing channelMap without lock (<a href="https://redirect.github.com/grpc/grpc-go/issues/7079">#7079</a>) (<a href="https://redirect.github.com/grpc/grpc-go/issues/7">#7</a>...</li> <li><a href="https://github.com/grpc/grpc-go/commit/e62770d76fc9508a2266d8bb8c6f2967e0dbc6fc"><code>e62770d</code></a> channelz: add LocalAddr to listen sockets and test (<a href="https://redirect.github.com/grpc/grpc-go/issues/7062">#7062</a>) (<a href="https://redirect.github.com/grpc/grpc-go/issues/7063">#7063</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/4ffccf1a5f97417eeb000d521f6415b6eb33bb5f"><code>4ffccf1</code></a> googlec2p: use xdstp style template for client LDS resource name (<a href="https://redirect.github.com/grpc/grpc-go/issues/7048">#7048</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/faf9964afe47a919a1469419413a0cae4bc86769"><code>faf9964</code></a> gracefulswitch: add ParseConfig and make UpdateClientConnState call SwitchTo ...</li> <li><a href="https://github.com/grpc/grpc-go/commit/800a8e02b5f25fa6aceb5771c0c263dae0928f8f"><code>800a8e0</code></a> channelz: re-add state for subchannels (<a href="https://redirect.github.com/grpc/grpc-go/issues/7046">#7046</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/dadbbfa2863a67ed640aac924b7b7fd18b50a429"><code>dadbbfa</code></a> channelz: re-add target and state (<a href="https://redirect.github.com/grpc/grpc-go/issues/7042">#7042</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/55cd7a68b3c18a0f76ea9c1be37221a5b901a798"><code>55cd7a6</code></a> channelz: major cleanup / reorganization (<a href="https://redirect.github.com/grpc/grpc-go/issues/6969">#6969</a>)</li> <li><a href="https://github.com/grpc/grpc-go/commit/a1033b1f44942fe30e3308ba85ee647e4187d97e"><code>a1033b1</code></a> xds: add LRS named metrics support (<a href="https://redirect.github.com/grpc/grpc-go/issues/7027">#7027</a>)</li> <li>Additional commits viewable in <a href="https://github.com/grpc/grpc-go/compare/v1.62.1...v1.63.0">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details>
* added new release branches * update json files * some fixes for failing tests * fix release version * chore: post v4.6.0, v5.4.0, v6.3.0, v7.4.0, v8.2.0 releases * add release-v7.4.x folder
…6118) Bumps [DavidAnson/markdownlint-cli2-action](https://github.com/davidanson/markdownlint-cli2-action) from 15 to 16. - [Release notes](https://github.com/davidanson/markdownlint-cli2-action/releases) - [Commits](DavidAnson/markdownlint-cli2-action@v15...v16) --- updated-dependencies: - dependency-name: DavidAnson/markdownlint-cli2-action dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n /modules/light-clients/08-wasm (#6097) * build(deps): Bump github.com/CosmWasm/wasmvm/v2 Bumps [github.com/CosmWasm/wasmvm/v2](https://github.com/CosmWasm/wasmvm) from 2.0.0 to 2.0.1. - [Release notes](https://github.com/CosmWasm/wasmvm/releases) - [Changelog](https://github.com/CosmWasm/wasmvm/blob/main/CHANGELOG.md) - [Commits](CosmWasm/wasmvm@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: github.com/CosmWasm/wasmvm/v2 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * e2e go mod tidy * add changelog --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: DimitrisJim <[email protected]>
* remove event emission * Update events.go * update test acrroding * update hermes tag --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Charly <[email protected]>
* Addressed lint issues for 03-connection * Address linter findings of 04-channel and 23-commitments * Address more findings.
* Address linter findings on core/02-client * Update modules/core/02-client/keeper/keeper.go Co-authored-by: Carlos Rodriguez <[email protected]> * Better panic messages. --------- Co-authored-by: Carlos Rodriguez <[email protected]>
* Address linting issues in apps/ * Update modules/apps/callbacks/testing/simapp/app.go Co-authored-by: Carlos Rodriguez <[email protected]> * Better panic messages --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Cian Hatton <[email protected]>
* Address linter issues in e2e/. * Update e2e/testsuite/testconfig.go Co-authored-by: Carlos Rodriguez <[email protected]> * Use aux variable to print type --------- Co-authored-by: Carlos Rodriguez <[email protected]> Co-authored-by: Cian Hatton <[email protected]>
* build(deps): Bump google.golang.org/grpc from 1.63.0 to 1.63.2 Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.63.0 to 1.63.2. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.63.0...v1.63.2) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * chore: make tidy-all --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Damian Nolan <[email protected]>
* chore: add extra defensive check to SendPacket * test: adding testcase for SendPacket client zero height
Co-authored-by: Nikolas De Giorgis <[email protected]> Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: DimitrisJim <[email protected]>
…ule entry points (#6074)
* Replace Router with PortKeeper in IBCKeeper. * Major refactoring of tests. * Remove non-working test code. * Update modules/core/05-port/keeper/keeper.go Co-authored-by: Cian Hatton <[email protected]> * Make GetRoute a method of *Keeper * Update 13-v8-to-v9.md * Update CHANGELOG.md * Update 13-v8-to-v9.md * Change GetRoute signature. --------- Co-authored-by: Cian Hatton <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
* chores: cleanup e2e * clean up
…host (#6130) * Address linting issues in various modules. * Fixed missing return * Linting issues in 09-localhost. * Update modules/light-clients/06-solomachine/store.go Co-authored-by: DimitrisJim <[email protected]> * Add newlines before return. --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
* build(deps): Bump cosmossdk.io/x/tx from 0.13.1 to 0.13.2 Bumps [cosmossdk.io/x/tx](https://github.com/cosmos/cosmos-sdk) from 0.13.1 to 0.13.2. - [Release notes](https://github.com/cosmos/cosmos-sdk/releases) - [Changelog](https://github.com/cosmos/cosmos-sdk/blob/main/CHANGELOG.md) - [Commits](cosmos/cosmos-sdk@v0.13.1...x/tx/v0.13.2) --- updated-dependencies: - dependency-name: cosmossdk.io/x/tx dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> * deps: bump x/tx to 0.13.2 and run tidy-all --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: DimitrisJim <[email protected]>
* Address linting issues in various modules. * Fixed missing return * Linting issues in 09-localhost. * Update modules/light-clients/06-solomachine/store.go Co-authored-by: DimitrisJim <[email protected]> * Add newlines before return. * Address lint issues in 07-tendermint * Address more linter issues in 07-tendermint. * Revert changes included in different PR * Revert changes included in different PR. * Revert changes. * Revert changes. --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: Damian Nolan <[email protected]>
* tests: move tests from client state to light client module for 08-wasm. * Remove usage of globals from 08-wasm (#6103) * Move functionality from client state methods to light client module methods. - Yank all statements and delete functions as needed. - Make any required functions from types/ public. - Add the vm in the 08-wasm keeper. - Update documentation to include documentation of deleted functions. * Remove global VM, introspection to retrieve client identifier. - Refactor signatures to explicitly pass vm, client identifier for time being. - Refactor tests to conform with new signatures. - Replace occurences of `ibcwasm.GetVM` in other keeper functions. * Move migrateContract from clientState to keeper method. - Matches moves for other functions. - Move is required to address future circular dependency for state management (keeper would import types and types would import keeper) - Rm migrate_contract(test).go files. * Move state management to keeper. - Remove globals for state (Checksums) - Move access functions from types to keeper, move tests. - Update calls using global to instead go through keeper. * Make InitializePinnedCodes a method on the keeper. * Remove pending todo in test for migrate contract. This previously was testing a function that didn't set the client state after calling the contract (invoking through the keeper always sets a client state after contract invocation). Hence, even if we don't set explicitly in the migrateFn callback, we _still_ get a client state in the end. * Move vm entrypoint functions in keeper/ package. * feat: move vm entry points to keeper. * chore: simplify signatures. * test: add amended tests for contact keeper. * refactor: move querier to keeper package. * lint: you'll never fix me. * refactor: remove queryRouter global variable - Move into the func for creating new plugins, pass it to acceptStargateQuery directly. This is probably what wasmd did (see they don't accept a query router now?). Since we don't use the get elsewhere, this was the smallest diff for a globa. - Preemptively ran make lint-fix, gotcha linting crybaby. * refactor: remove global for query plugins. * nit: rename to queryPlugins. * refactor: remove QueryPluginsI interface. * refactor: make queryHandler a private type. * Make migrateContractCode a private function, clean up uneeded export in export_test.go for types/. * refactor: Move vm entrypoints to keeper. - Remove generic types and do unmarshalling in light client methods. - Move all functions onto keeper and adjust call sites. * chore: address some testing todos. Move testing unmarshal failure case to light client tests. * chore: additional tiny nits. - Consistently use wasmClientKeeper as local var name. - Reorg keeper fields slightly. - Rm 'vm.go' which was already empty. * chore: restructure definitions to make diff more readable. * d'oh: rm vm arg from instantiate. * nit: Space out keeper fields. Remove TODO for method name. * chore: address remaining TODOs. * nit: don't hold ref to schema after building it. * Update modules/light-clients/08-wasm/types/gas_register.go Co-authored-by: Damian Nolan <[email protected]> * lint: shut up --------- Co-authored-by: Damian Nolan <[email protected]>
* Address lint findings in testing/ * Remove nolint directive --------- Co-authored-by: DimitrisJim <[email protected]>
* e2e: testsuite updated * test: fixed client_test * test: fixed ica tests * e2e: query refactor and fix more tests * test: fixed more tests * style: ran 'golangci-lint' * style: renamed query methods * refactor: fix more golangci-lint errors * e2e: attempted fix of client state query * test: fix and refactor * test: attempted fix of cmttypes * imp: fixed queries for cmttypes * fix: attempted fix for assert relayed * fix: assert relayed * imp: client fix * fix: new test * docs: fix godocs * style: ran golangci-lint --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
* nit: add documentation for private methods that are too spicy (re: complex) to not document. * Update modules/light-clients/08-wasm/keeper/keeper.go Co-authored-by: Damian Nolan <[email protected]> --------- Co-authored-by: Damian Nolan <[email protected]>
* refactor(modules/core): use asset events instead of assert event legacy * refactor(modules/apps): use asset events instead of assert event legacy * refactor: remove asset events legacy and events map * fix: linter errors * fix: linter errors * fix linter errors * add migration docs * add changelog --------- Co-authored-by: DimitrisJim <[email protected]> Co-authored-by: Charly <[email protected]> Co-authored-by: Carlos Rodriguez <[email protected]>
* fix: no-op rather than panic in solomachine update state * Update modules/light-clients/06-solomachine/update.go Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> * add changelog --------- Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com> Co-authored-by: Carlos Rodriguez <[email protected]>
…xecution (#6278) * performance: exit early on recvpacket to exclude app callbacks * perf: skip pruning on check tx and recheck tx * change fmt.Errorf to errors.New * fix: check execMode simulate in conditional * revert: recv packet changes * fix: account for simulation in pruning check * fix: reuse checkTx ctx * chore: add changelog --------- Co-authored-by: Damian Nolan <[email protected]>
* perf: only perform core ibc logic on recvpacket checktx * try me linter * fix: reorder if and add comment * chore: add changelog entry
Bumps [JamesIves/github-pages-deploy-action](https://github.com/jamesives/github-pages-deploy-action) from 4.6.0 to 4.6.1. - [Release notes](https://github.com/jamesives/github-pages-deploy-action/releases) - [Commits](JamesIves/github-pages-deploy-action@v4.6.0...v4.6.1) --- updated-dependencies: - dependency-name: JamesIves/github-pages-deploy-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <[email protected]>
) Bumps [bufbuild/buf-setup-action](https://github.com/bufbuild/buf-setup-action) from 1.31.0 to 1.32.0. - [Release notes](https://github.com/bufbuild/buf-setup-action/releases) - [Commits](bufbuild/buf-setup-action@v1.31.0...v1.32.0) --- updated-dependencies: - dependency-name: bufbuild/buf-setup-action dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: colin axnér <[email protected]>
* perf: minimize logic on rechecktx for recvpacket * refactor: rework layout for recvpacket rechecktx * test: add tests for 04-channel rechecktx func * test: add tests for core ante handler * chore: add comment explaining is rechecktx usage * linter appeasement * chore: add changelog entry * Update modules/core/ante/ante.go Co-authored-by: Carlos Rodriguez <[email protected]> * imp: use cached ctx for consistency * refactor: change added test to use expected errors * lint --------- Co-authored-by: Carlos Rodriguez <[email protected]>
|
Important Review SkippedAuto reviews are disabled on base/target branches other than the default branch. Please add the base/target branch pattern to the list of additional branches to be reviewed in the settings. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
chatton
requested review from
colin-axner,
AdityaSripal,
crodriguezvega,
charleenfei,
damiannolan,
DimitrisJim and
srdtrk
as code owners
chatton
commented
May 21, 2024
| if !slices.Contains(types.SupportedVersions, counterpartyVersion) { | ||
| return types.V2, nil | ||
| } | ||
|
|
There was a problem hiding this comment.
This was the only change that happened, there was actually a bug where the capability wasn't being claimed correctly which happened when the default V2 was returned. We now claim capability before this return.
colin-axner
approved these changes
May 21, 2024
DimitrisJim
approved these changes
May 21, 2024
|
looks like we have linting failures |
|
damiannolan
approved these changes
May 21, 2024
|
merging via 'create merge commit' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR pulls in all changes in main to the feature branch
NOTE: I have temporarily enabled merge commits for this PR, we must not squash and merge this PR otherwise we'll need to start over.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/).godoccomments.Files changedin the GitHub PR explorer.SonarCloud Reportin the comment section below once CI passes.