-
Notifications
You must be signed in to change notification settings - Fork 606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
e2e cleanup #6145
e2e cleanup #6145
Conversation
WalkthroughWalkthroughThe recent changes involve a systematic update to various JSON configuration files related to compatibility testing matrices for different chains. The focus was on removing outdated software versions and incorporating new versions to enhance testing efficiency and accuracy across different chains. Changes
Possibly related issues
Recent Review DetailsConfiguration used: .coderabbit.yml Files selected for processing (1)
Files skipped from review due to trivial changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
"v6.3.0", | ||
"v5.4.0", | ||
"v4.6.0", | ||
"v3.4.0", | ||
"v2.5.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added here the latest tags for the previous releases that are already EoL (except v1, for which there is no docker image). I think this is good to do, even if those release lines are not supported anymore, just to make sure that we keep backwards compatibility, but I am open to hear everyone's thoughts.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's strictly necessary but it's no harm, especially since some of these versions are still in use.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for cleaning up these matricies 🥇
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice one, thanks for taking care of these! 🚀
* chores: cleanup e2e * clean up
Description
Unreleased compatibility tests passed from this branch here.
Compatibility tests for v8.2.x here (failures should be fixed with #6142)
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.Summary by CodeRabbit