-
Notifications
You must be signed in to change notification settings - Fork 597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chores after releases for ASA-2024-007 #6096
Conversation
Important Auto Review SkippedMore than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review. 99 files out of 289 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we need to maintain all the compatibility tests for retracted versions?
I will clean this up in a follow up PR, but I think I am going to add the latest tags of each major version to the compatibility tests of the currently supported versions, even if those major versions are EoL. At the end of the day, even if they are EoL it would still be nice that we don't break compatibility. |
i kind of feel like keeping the compatibility tests in might signal something contrary to EoL, though, so maybe that's something to discuss internally. i remember this topic coming up before and i think we decided to not keep the EoL tags in for that reasoning...but maybe worth discussing again. |
Description
closes: #XXXX
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/
).godoc
comments.Files changed
in the GitHub PR explorer.SonarCloud Report
in the comment section below once CI passes.