-
Notifications
You must be signed in to change notification settings - Fork 161
fix error of timeout when using Truffle to deploy contract #768
Conversation
evm: reset cache after csdb is committed (cosmos#676)
update development
update development
update development
update development branch
update branch
update development
rpc: fix method to calculate block hash and fix mismatch block hash i…
@@ -125,7 +125,7 @@ func EthTransactionsFromTendermint(clientCtx clientcontext.CLIContext, txs []tmt | |||
continue | |||
} | |||
// TODO: Remove gas usage calculation if saving gasUsed per block | |||
gasUsed.Add(gasUsed, ethTx.Fee()) | |||
gasUsed.Add(gasUsed, big.NewInt(int64(ethTx.GetGas()))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GetGas() just gives the gas limit correct?
would it be better to use:
gasUsed.Add(gasUsed, ethTx.Fee().Int64())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think here need return gas used, not gas fee used, also, the number of Fee() is too big to return to the interface of web3.js, that will be crashed in web3.js lib cause too large number transform
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ethTx.Fee() return gaslimit * gasPrice, its much larger than real number of gas costed
Closes: #767
Description
For contributor use:
docs/
) or specification (x/<module>/spec/
)godoc
comments.Unreleased
section inCHANGELOG.md
Files changed
in the Github PR explorerFor admin use:
WIP
,R4R
,docs
, etc)