Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update development #8

Merged
merged 2 commits into from
Jan 30, 2021
Merged

update development #8

merged 2 commits into from
Jan 30, 2021

Conversation

KamiD
Copy link
Owner

@KamiD KamiD commented Jan 30, 2021

Closes: #XXX

Description

For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

KamiD and others added 2 commits January 28, 2021 13:30
@KamiD @fedekunze
x/evm: open eip2028 when the version of Istanbul was enabled (#731)
c95ad04 
* open eip2028 when Istanbul version enabled

* Update x/evm/types/chain_config.go

Co-authored-by: Federico Kunze <[email protected]>

* Update x/evm/types/chain_config.go

Co-authored-by: Federico Kunze <[email protected]>

* add change log

* update development

* fix rpc test error

Co-authored-by: Federico Kunze <[email protected]>
@AaronZgl @fedekunze
ante: fix fee print error (#756)
e1349e4 
Co-authored-by: Federico Kunze <[email protected]>
@KamiD KamiD merged commit bba87fc into KamiD:development Jan 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KamiD @AaronZgl