Skip to content
This repository has been archived by the owner on Nov 30, 2021. It is now read-only.

fix error of timeout when using Truffle to deploy contract #768

Merged
merged 13 commits into from
Feb 8, 2021
Merged

fix error of timeout when using Truffle to deploy contract #768

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
9a1e894
Merge pull request #2 from cosmos/development
KamiD Dec 31, 2020
ae8d04f
Merge pull request #3 from cosmos/development
KamiD Jan 7, 2021
3ac7c8f
Merge pull request #4 from cosmos/development
KamiD Jan 13, 2021
3e67719
Merge pull request #5 from cosmos/development
KamiD Jan 20, 2021
b498499
Merge pull request #6 from cosmos/development
KamiD Jan 27, 2021
714260d
Merge pull request #7 from cosmos/development
KamiD Jan 28, 2021
bba87fc
Merge pull request #8 from cosmos/development
KamiD Jan 30, 2021
6213e66
Merge pull request #9 from cosmos/development
KamiD Feb 1, 2021
5bce35b
fix error of timeout when using Truffle to deploy contract
KamiD Feb 3, 2021
55baa8a
fix CHANGELOG.MD
KamiD Feb 3, 2021
1bab751
Merge branch 'development' into hotfix-v0.4.1
KamiD Feb 4, 2021
56edebd
Merge branch 'development' into hotfix-v0.4.1
KamiD Feb 5, 2021
30c8905
Merge branch 'development' into hotfix-v0.4.1
araskachoi Feb 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ Ref: https://keepachangelog.com/en/1.0.0/
* (evm) [\#670](https://github.com/cosmos/ethermint/pull/670) Migrate types to the ones defined by the protobuf messages, which are required for the stargate release.

### Bug Fixes

* (evm) [\#767](https://github.com/cosmos/ethermint/issues/767) Fix error of timeout when using Truffle to deploy contract.
* (evm) [\#751](https://github.com/cosmos/ethermint/issues/751) Fix misused method to calculate block hash in evm related function.
* (evm) [\#721](https://github.com/cosmos/ethermint/issues/721) Fix mismatch block hash in rpc response when use eht.getBlock.
* (evm) [\#730](https://github.com/cosmos/ethermint/issues/730) Fix 'EIP2028' not open when Istanbul version has been enabled.
Expand Down
2 changes: 1 addition & 1 deletion rpc/types/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ func EthTransactionsFromTendermint(clientCtx clientcontext.CLIContext, txs []tmt
continue
}
// TODO: Remove gas usage calculation if saving gasUsed per block
gasUsed.Add(gasUsed, ethTx.Fee())
gasUsed.Add(gasUsed, big.NewInt(int64(ethTx.GetGas())))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GetGas() just gives the gas limit correct?
would it be better to use:
gasUsed.Add(gasUsed, ethTx.Fee().Int64())

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think here need return gas used, not gas fee used, also, the number of Fee() is too big to return to the interface of web3.js, that will be crashed in web3.js lib cause too large number transform

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ethTx.Fee() return gaslimit * gasPrice, its much larger than real number of gas costed

transactionHashes = append(transactionHashes, common.BytesToHash(tx.Hash()))
}

Expand Down