R4R: Release 0.25.0 #2588

cwgoes · 2018-10-24T13:33:17Z

PR to release v0.25.0.

For Admin Use:

Added appropriate labels to PR (ex. wip, ready-for-review, docs)
Reviewers Assigned
Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

* Correctly set proposer in randomized simulation * Return nil if no validators are present

…tion

…smos-sdk into rigel/fee-distribution

@anton

This is basically copying over @anton's great script! Also had to run `make format` to make this pass `test_lint`. This PR also makes the make commands for tools further align with the tendermint implementation.

* Add arg to PrintUnsignedStdTx() to actually operate in offline mode * WIP simplifying server module * Expose ExternalIP() * Move {GenTx,Init}Cmd into gaia's new init package

codecov · 2018-10-24T13:34:33Z

Codecov Report

Merging #2588 into master will decrease coverage by 4.91%.
The diff coverage is 36.78%.

@@            Coverage Diff             @@
##           master    #2588      +/-   ##
==========================================
- Coverage   63.76%   58.85%   -4.92%     
==========================================
  Files         113      152      +39     
  Lines        6671     9411    +2740     
==========================================
+ Hits         4254     5539    +1285     
- Misses       2131     3503    +1372     
- Partials      286      369      +83

cwgoes · 2018-10-24T15:47:42Z

PR to merge release branch back to develop (#6 on the release checklist): #2590

alexanderbez · 2018-10-24T16:15:19Z

Took a look at the few latest changes, which LGTM.

alexanderbez · 2018-10-24T20:18:15Z

Ignore my previous comments (which I deleted). Thing that I have tried to do that failed is creating a new key:

$ gaiacli keys new foo entering all defaults except my passphrase. I get the following:

panic: Panicked on a Crisis: leveldb: read-only mode

goroutine 1 [running]:
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/common.PanicCrisis(0x494e560, 0xc000186090)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/common/errors.go:232 +0xb8
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db.(*GoLevelDB).SetSync(0xc0001a0170, 0xc00019a768, 0x8, 0x8, 0xc0001c81c0, 0x125, 0x1a3)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/db/go_level_db.go:80 +0xc7
github.com/cosmos/cosmos-sdk/crypto/keys.dbKeybase.writeInfo(0x4f02920, 0xc0001a0170, 0x4efaa60, 0xc0001fb5c0, 0x7ffeefbffa41, 0x3)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:460 +0xc5
github.com/cosmos/cosmos-sdk/crypto/keys.dbKeybase.writeLocalKey(0x4f02920, 0xc0001a0170, 0x4efbce0, 0xc00019c7e0, 0x7ffeefbffa41, 0x3, 0xc000af6028, 0x8, 0xc0001f41c0, 0xf)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:441 +0x140
github.com/cosmos/cosmos-sdk/crypto/keys.(*dbKeybase).persistDerivedKey(0xc0004a1838, 0xc0000342c0, 0x40, 0x40, 0xc000af6028, 0x8, 0x7ffeefbffa41, 0x3, 0xc0001f41c0, 0xf, ...)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:189 +0x23f
github.com/cosmos/cosmos-sdk/crypto/keys.dbKeybase.Derive(0x4f02920, 0xc0001a0170, 0x7ffeefbffa41, 0x3, 0xc00003c140, 0x92, 0x0, 0x0, 0xc000af6028, 0x8, ...)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/crypto/keys/keybase.go:153 +0x15a
github.com/cosmos/cosmos-sdk/client/keys.runNewCmd(0xc000b78b40, 0xc000b81030, 0x1, 0x1, 0x0, 0x0)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/client/keys/new.go:142 +0x428
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).execute(0xc000b78b40, 0xc000b81000, 0x1, 0x1, 0xc000b78b40, 0xc000b81000)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:698 +0x47a
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0x5633ba0, 0x6, 0xc000b8ad20, 0x0)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:783 +0x2dc
github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra.(*Command).Execute(0x5633ba0, 0x4a73870, 0x6)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/spf13/cobra/command.go:736 +0x2b
github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/cli.Executor.Execute(0x5633ba0, 0x4e2fef8, 0x0, 0xc00011fc20)
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/vendor/github.com/tendermint/tendermint/libs/cli/setup.go:89 +0x4e
main.main()
	/Users/aleksbez/go/src/github.com/cosmos/cosmos-sdk/cmd/gaia/cmd/gaiacli/main.go:140 +0xca9

/cc @alessio

jackzampolin · 2018-10-24T21:41:40Z

This is the fix right @alexanderbez? #2593

alexanderbez · 2018-10-25T01:30:38Z

Yes.

Fix DB Write Permissions for gaia keys new

cwgoes · 2018-10-25T11:53:27Z

Caught another issue with multi-seed simulation.

edit: Let's track this further on #2573.

cwgoes · 2018-10-25T12:30:52Z

The release branch has been merged back to develop. Closing this so we can debug the simulation failures.

Let's open a new release branch and re-run the release process when we've found the underlying issue.

mossid and others added 30 commits October 9, 2018 21:05

fix prefixIterator

5237639

partially apply requests

5091d16

fix cloneAppend

c770e74

port tests from tmlibs, fix tests

e7c76eb

fix Close()

43b3352

fix typo

ed9b29c

rm Close() from Next()

0cbb37f

mv types/lib/* store/

0c92477

create test initialization for distr

46fe52b

Merge PR #2255: Offset validator set power calculations by one block

e13bbe2

...

c973032

Merge PR #2452: Fix LCD Validator Initialization

e251088

Fix IBC paper link

963bcaf

R4R: Fix simulation proposer (#2460)

6d4975e

* Correctly set proposer in randomized simulation * Return nil if no validators are present

Merge remote-tracking branch 'origin/develop' into rigel/fee-distribu…

fc9bafb

…tion

staking changes test_cover fixes

151a81e

Merge branch 'rigel/fee-distribution' of https://github.com/cosmos/co…

ace19d9

…smos-sdk into rigel/fee-distribution

fix initialization of the test

52316d9

fix distr initialization

22de856

Lock binary dependencies to a specific commits / versions

9e334af

This is basically copying over @anton's great script! Also had to run `make format` to make this pass `test_lint`. This PR also makes the make commands for tools further align with the tendermint implementation.

Update changelog

58bedad

Merge branch 'develop' into joon/paramstore-refactor-base

0397540

rename store subspace, add WithTypeTable

5c92a54

ctx with proposer, working through allocation test

3b5e57b

Alessio/server refactor (#2472)

0f4a03b

* Add arg to PrintUnsignedStdTx() to actually operate in offline mode * WIP simplifying server module * Expose ExternalIP() * Move {GenTx,Init}Cmd into gaia's new init package

Disable unparam

0ef1582

Merge PR #2461: Fix IBC paper link

7d45998

keeper_test

900a5f4

allocation tests

f4f39ae

got basic delegation tests working

8e378e2

Merge PR #2554: Make gaiacli keys show multisig-ready

c577831

cwgoes requested review from ebuchman, rigelrozanski and zramsay as code owners October 24, 2018 13:33

Merge branch 'master' into release/v0.25.0

a9d9eb5

cwgoes added the wip label Oct 24, 2018

cwgoes added 2 commits October 24, 2018 15:37

'make format'

2342621

Move PENDING to CHANGELOG

d33cc7c

cwgoes added the game-of-stakes label Oct 24, 2018

Linkify changelog

075ddce

cwgoes mentioned this pull request Oct 24, 2018

[R4R] #1255 make keybase opened with readonly option for query-purpose cli commands #2489

Merged

5 tasks

cwgoes changed the title ~~WIP: Release 0.25.0~~ R4R: Release 0.25.0 Oct 24, 2018

cwgoes added ready-for-review and removed wip labels Oct 24, 2018

Aleksandr Bezobchuk added 2 commits October 24, 2018 16:34

Fix db write perm

23f62f7

Additional cleanup

507438b

alessio and others added 2 commits October 24, 2018 19:43

Merge pull request #2593 from cosmos/bez/fix-keys-new-perm

ebca085

Fix DB Write Permissions for gaia keys new

Remove logs from prior debugging

2a279e9

cwgoes force-pushed the release/v0.25.0 branch from 5ddfe7a to 2a279e9 Compare October 25, 2018 11:23

cwgoes mentioned this pull request Oct 25, 2018

Add accum tracking invariants #2573

Closed

cwgoes closed this Oct 25, 2018

cwgoes deleted the release/v0.25.0 branch October 25, 2018 12:31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

R4R: Release 0.25.0 #2588

R4R: Release 0.25.0 #2588

cwgoes commented Oct 24, 2018 •

edited

Loading

codecov bot commented Oct 24, 2018 •

edited

Loading

cwgoes commented Oct 24, 2018 •

edited

Loading

alexanderbez commented Oct 24, 2018

alexanderbez commented Oct 24, 2018

jackzampolin commented Oct 24, 2018 •

edited

Loading

alexanderbez commented Oct 25, 2018

cwgoes commented Oct 25, 2018 •

edited

Loading

cwgoes commented Oct 25, 2018

R4R: Release 0.25.0 #2588

R4R: Release 0.25.0 #2588

Conversation

cwgoes commented Oct 24, 2018 • edited Loading

codecov bot commented Oct 24, 2018 • edited Loading

Codecov Report

cwgoes commented Oct 24, 2018 • edited Loading

alexanderbez commented Oct 24, 2018

alexanderbez commented Oct 24, 2018

jackzampolin commented Oct 24, 2018 • edited Loading

alexanderbez commented Oct 25, 2018

cwgoes commented Oct 25, 2018 • edited Loading

cwgoes commented Oct 25, 2018

cwgoes commented Oct 24, 2018 •

edited

Loading

codecov bot commented Oct 24, 2018 •

edited

Loading

cwgoes commented Oct 24, 2018 •

edited

Loading

jackzampolin commented Oct 24, 2018 •

edited

Loading

cwgoes commented Oct 25, 2018 •

edited

Loading