Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IBC paper link #2461

Merged
merged 2 commits into from
Oct 11, 2018
Merged

Fix IBC paper link #2461

merged 2 commits into from
Oct 11, 2018

Conversation

cwgoes
Copy link
Contributor

@cwgoes cwgoes commented Oct 9, 2018

Closes #2457


For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@cwgoes cwgoes added T:Docs Changes and features related to documentation. ready-for-review labels Oct 9, 2018
@cwgoes cwgoes requested a review from zramsay as a code owner October 9, 2018 21:14
@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 9, 2018

No idea why this causes the linter to suddenly fail on unrelated code.

@cwgoes
Copy link
Contributor Author

cwgoes commented Oct 10, 2018

Disabled the unparam linter for now - either we should actually use it (and not just write a bunch of // nolint comments) or we should ditch it. Maybe we can add it back later when the code is more stable.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@e251088). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             develop    #2461   +/-   ##
==========================================
  Coverage           ?   59.96%           
==========================================
  Files              ?      136           
  Lines              ?     8468           
  Branches           ?        0           
==========================================
  Hits               ?     5078           
  Misses             ?     3054           
  Partials           ?      336

@cwgoes cwgoes merged commit 7d45998 into develop Oct 11, 2018
@cwgoes cwgoes deleted the cwgoes/fix-ibc-paper-link branch October 11, 2018 00:14
chillyvee pushed a commit to chillyvee/cosmos-sdk that referenced this pull request Mar 1, 2024
Co-authored-by: Milan Mulji <[email protected]>
Co-authored-by: Marius Poke <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T:Docs Changes and features related to documentation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants