Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Alessio/server refactor #2472

Merged
merged 4 commits into from
Oct 10, 2018
Merged

WIP: Alessio/server refactor #2472

merged 4 commits into from
Oct 10, 2018

Conversation

alessio
Copy link
Contributor

@alessio alessio commented Oct 10, 2018

  • Linked to github-issue with discussion and accepted design OR link to spec that describes this work.
  • Wrote tests
  • Updated relevant documentation (docs/)
  • Added entries in PENDING.md with issue #
  • rereviewed Files changed in the github PR explorer

For Admin Use:

  • Added appropriate labels to PR (ex. wip, ready-for-review, docs)
  • Reviewers Assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

❗ No coverage uploaded for pull request base (develop@e251088). Click here to learn what that means.
The diff coverage is 32.24%.

@@            Coverage Diff            @@
##             develop   #2472   +/-   ##
=========================================
  Coverage           ?   60.8%           
=========================================
  Files              ?     125           
  Lines              ?    7642           
  Branches           ?       0           
=========================================
  Hits               ?    4647           
  Misses             ?    2681           
  Partials           ?     314

@jaekwon
Copy link
Contributor

jaekwon commented Oct 10, 2018

LGTM, this is part of an ongoing refactor, with discussion w/ Chris and myself.

@jaekwon jaekwon merged commit 0f4a03b into develop Oct 10, 2018
@cwgoes cwgoes deleted the alessio/server-refactor branch October 10, 2018 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants