Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking #10033

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix!: x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking #10033

merged 1 commit into from
Aug 30, 2021

Conversation

odeke-em
Copy link
Collaborator

To ensure that benchmarking of all other commits can proceed without
errors, which block the entire process.

Updates #10023

Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • followed the guidelines for building modules
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

…king

To ensure that benchmarking of all other commits can proceed without
errors, which block the entire process.

Updates #10023
@codecov
Copy link

codecov bot commented Aug 30, 2021

Codecov Report

Merging #10033 (c6435b7) into master (ccd95f3) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #10033   +/-   ##
=======================================
  Coverage   63.56%   63.57%           
=======================================
  Files         572      572           
  Lines       53598    53598           
=======================================
+ Hits        34072    34073    +1     
+ Misses      17582    17581    -1     
  Partials     1944     1944           
Impacted Files Coverage Δ
crypto/keys/internal/ecdsa/privkey.go 84.21% <0.00%> (+1.75%) ⬆️

@tac0turtle tac0turtle changed the title x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking fix!: x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking Aug 30, 2021
@alexanderbez alexanderbez merged commit 0745320 into cosmos:master Aug 30, 2021
@orijbot
Copy link

orijbot commented Aug 30, 2021

@odeke-em odeke-em deleted the x-bank-Skip-failing-benchmarks-to-unblock-benchmarking branch August 30, 2021 19:52
@odeke-em
Copy link
Collaborator Author

Thank you @marbar3778 and @alexanderbez for the reviews and merge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants