Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking #10033

Merged
merged 1 commit into from
Aug 30, 2021
Merged

fix!: x/bank: skip failing BenchmarkOneBankSend* to avoid blocking benchmarking #10033

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions x/bank/bench_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ import (
var moduleAccAddr = authtypes.NewModuleAddress(stakingtypes.BondedPoolName)

func BenchmarkOneBankSendTxPerBlock(b *testing.B) {
b.Skip("Skipping benchmark with buggy code reported at https://github.com/cosmos/cosmos-sdk/issues/10023")

b.ReportAllocs()
// Add an account at genesis
acc := authtypes.BaseAccount{
Expand Down Expand Up @@ -61,6 +63,8 @@ func BenchmarkOneBankSendTxPerBlock(b *testing.B) {
}

func BenchmarkOneBankMultiSendTxPerBlock(b *testing.B) {
b.Skip("Skipping benchmark with buggy code reported at https://github.com/cosmos/cosmos-sdk/issues/10023")

b.ReportAllocs()
// Add an account at genesis
acc := authtypes.BaseAccount{
Expand Down