Story/14171 support sharing self test #4891
Conversation
…nges for self test submission.
…manage-your-tests-screen
…manage-your-tests-screen
This reverts commit c91156a.
…anges Task/14350 adapt new changes
…Finalise-submission-process
naveeddotio
added
task
…Finalise-submission-process
…mission-process Task/14279 finalise submission process
There was a problem hiding this comment.
Overall this looks very good. I made some comments. The stuff that I think is important for you to look at and check I marked with
All the other stuff is optional I think and up to your own consideration, if you want to change something about these or not 🤓
| @testable import ENA | ||
|
|
There was a problem hiding this comment.
Looks like this file was added to the ENA target, so I would recommend to wrap it into #if DEBUG ... #endif to prevent it from being shipped or accidentally used in production.
...NA/ENA/Resources/Assets/Assets.xcassets/Common/Icons - ContactJournal.imageset/Contents.json
Show resolved
Hide resolved
src/xcode/ENA/ENA/Resources/Assets/Assets.xcassets/Common/Icons_Risikoermittlung/Contents.json
Show resolved
Hide resolved
| @@ -13605,6 +13739,7 @@ | |||
| CODE_SIGN_STYLE = Manual; | |||
| CURRENT_PROJECT_VERSION = 0; | |||
| DEVELOPMENT_TEAM = 523TP53AQF; | |||
| "DEVELOPMENT_TEAM[sdk=iphoneos*]" = 523TP53AQF; | |||
There was a problem hiding this comment.
Conscious choice to add this change? (I'm not saying it's bad, I have no idea, just not sure if necessary)
| @@ -13628,6 +13763,7 @@ | |||
| PRODUCT_BUNDLE_IDENTIFIER = "de.rki.coronawarnapp-dev"; | |||
| PRODUCT_NAME = "$(TARGET_NAME)"; | |||
| PROVISIONING_PROFILE_SPECIFIER = $IPHONE_APP_DIST_PROF_SPECIFIER; | |||
| "PROVISIONING_PROFILE_SPECIFIER[sdk=iphoneos*]" = "Corona-Warn-App-Dev1"; | |||
| @@ -81,7 +81,7 @@ class ENAUITests_11_QuickActions: CWATestCase { | |||
| XCTAssertTrue(app.segmentedControls[AccessibilityIdentifiers.ContactDiary.segmentedControl].waitForExistence(timeout: .short)) | |||
| } | |||
|
|
|||
|
|
|||
| /* Commented out in favour SRS story | |||
There was a problem hiding this comment.
I think it still makes sense to have a test like that, but you probably need to find a new way to test through the submission instead of using a TAN
| @@ -250,6 +250,7 @@ class ENAUITests_04a_ExposureSubmission: CWATestCase { | |||
|
|
|||
| } | |||
|
|
|||
| /* Commented out in favour of SRS story | |||
There was a problem hiding this comment.
Also makes sense to consider different tests and if not, delete the dead code
Description
Merging storybranch into release branch
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14171