Task/14315 error handling

[flxschmidt]

Description

Implements a API in ExposureSubmissionCoordinator to show alerts regarding SRS Self Report Flow.

Usage

You only have to call showSRSFlowAlert(for:isLoading:), for example by a callback handler of a SRSFlow ViewController.
The method expect a type of an SRSFlowAlert that can be:

• .preconditionFailed (like app usage time)
• .consent (like cancel to warn, or confirm to warn)
• .error (for multiple errors)

Regarding Errors

The .error(error) expects as an associated value, the regarding Error type, to show the regarding SRS Error alert with the specific alert message for that. Errors to give in, have to be conformable to two protocols: SRSErrorAlertProviding and ErrorCodeProviding

The following Error types are now conformable to that:

• SRSError
• PPACError
• OTPError

Example

// Will show the "SUBMISSION_TOO_EARLY" alert message with error code 
// and the time from App Configuration parameter inside
showSRSFlowAlert(for: .error(PPACError.submissionTooEarly), isLoading: isLoading)

Open Points

• Implementation of .error at the specific code (further story task)
• cancel consent alert in showCheckinsScreen dismiss handler

Link to Jira

https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14315

Screenshots

SRS Precondition was failed

Some Errors on Screens

Consent Confirm Warn Others

Updated

Consent Cancel Warn Others

Updated

[Ein-Tim]

Some comments on the suggested actions on the pop-ups:

"Sind Sie sicher, dass Sie jetzt andere Personen, mit denen Sie in letzter Zeit Kontakt hatten, warnen wollen?" -> Here I would expect "Andere Warnen" to be in bold (=the suggested actions) and not "Abbrechen".

"Warn-Vorgang abbrechen" -> Here I would expect "Warnen fortsetzten" to be in bold and not "Abbrechen".

[flxschmidt]

Some comments on the suggested actions on the pop-ups:

"Sind Sie sicher, dass Sie jetzt andere Personen, mit denen Sie in letzter Zeit Kontakt hatten, warnen wollen?" -> Here I would expect "Andere Warnen" to be in bold (=the suggested actions) and not "Abbrechen".

"Warn-Vorgang abbrechen" -> Here I would expect "Warnen fortsetzten" to be in bold and not "Abbrechen".

You're right, and I have implemented that. The screenshots are updated as well. Thank you!

[Ein-Tim]

Thank you very much @flxschmidt!

[nickguendling]

Just some minor comments and I think one finding that might be critical, marked it with a ⚠️ again

[nickguendling]

Couldn't you present on the navigation controller as we do in other places? Then you could get rid of the view controller reference and even get rid of the implicitly unwrapped view controller in this place I think 🤔

[flxschmidt]

That was my first approach, but unfortunately that was not possible, because nav controller is already presenting a VC. Wo don't know which VC is the top most one. I also tried some SOF approaches, but the simplest way is, to give the VC as an associated value to the type.