This repository has been archived by the owner on Jun 20, 2023. It is now read-only.
Task/14360 Add dev menu toggle for pre-checks #4902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
reviewed
Nov 28, 2022
src/xcode/ENA/ENA/Source/Developer Menu/DMSrsPrechecks/DMSrsPrechecksViewController.swift
Outdated
Show resolved
Hide resolved
naveeddotio
reviewed
Nov 28, 2022
src/xcode/ENA/ENA/Source/Developer Menu/DMSrsPrechecks/DMSrsPrechecksViewModel.swift
Outdated
Show resolved
Hide resolved
naveeddotio
reviewed
Nov 28, 2022
src/xcode/ENA/ENA/Source/Developer Menu/DMSrsPrechecks/DMSrsPrechecksViewModel.swift
Outdated
Show resolved
Hide resolved
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
reviewed
Nov 28, 2022
src/xcode/ENA/ENA/Source/Developer Menu/Helper/DMMenuItem.swift
Outdated
Show resolved
Hide resolved
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
reviewed
Nov 28, 2022
naveeddotio
approved these changes
Nov 29, 2022
flxschmidt
approved these changes
Nov 29, 2022
| let cellViewModel = viewModel.cellViewModel(by: indexPath) | ||
| if cellViewModel is DMSwitchCellViewModel { | ||
| guard let cell = tableView.dequeueReusableCell(withIdentifier: DMSwitchTableViewCell.reuseIdentifier) as? DMSwitchTableViewCell else { | ||
| fatalError("unsupported cellViewModel - can't find a matching cell") |
There was a problem hiding this comment.
Do we have an alternative way, instead of App Crash? Alert that something goes wrong or something? I know, it's the Dev Menu, so it's not so important (this remark)
There was a problem hiding this comment.
Good point, let's discuss this in our calls when Omar is back
naveeddotio
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add dev menu toggle for prechecks
Link to Jira
https://jira-ibs.wbs.net.sap/browse/EXPOSUREAPP-14360
Screenshots
RPReplay_Final1669650306.MP4