This repository has been archived by the owner on May 7, 2021. It is now read-only.
ore/gcloud: Add --write-url argument #1171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreos-assembler was trying to re-create the URL that ore computed for the storage, and a recent refactoring broke that. Add an option to write out the URL we used so we only need to have its computation in one place. Specifically, cosa started replacing `.` with `-` but ore wasn't. xref coreos/coreos-assembler#1078
|
Maybe we should try to consistently have |
jlebon
approved these changes
Jan 28, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coreos-assembler was trying to re-create the URL that ore computed
for the storage, and a recent refactoring broke that.
Add an option to write out the URL we used so we only need
to have its computation in one place.
Specifically, cosa started replacing
.with-but ore wasn't.xref coreos/coreos-assembler#1078