gcp: Fix invalid URL in metadata #1079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Depends on coreos/mantle#1171 |
|
Tested that this fixes the issue BTW. |
Get the URL from what mantle computed rather than trying to re-compute it here. Closes: coreos#1078
cgwalters
force-pushed
the
gcp-regression
branch
from
f188be3 to
cc9b89a
Compare
|
#1082 brings in the necessary |
miabbott
approved these changes
Jan 28, 2020
miabbott
added a commit
to miabbott/installer
that referenced
this pull request
Jan 29, 2020
The problem with the RHCOS image on GCP was fixed with coreos/coreos-assembler#1079 and new images have been produced using the fixed `coreos-assembler`. Signed-off-by: Micah Abbott <[email protected]>
jcajka
pushed a commit
to jcajka/coreos-assembler
that referenced
this pull request
Mar 24, 2020
Some `kola spawn` enhancements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get the URL from what mantle computed rather than trying to re-compute
it here.
Closes: #1078